Enable RPM and Deb package uploads to packages.smallstep.com#202
Merged
Conversation
maraino
reviewed
Dec 17, 2024
Contributor
maraino
left a comment
maraino
left a comment
There was a problem hiding this comment.
It looks good in general, My only concern is that I think this requires goreleaser-pro, and to use goreleaser-cross with goreleaser-pro you need to use a goreleaser-cross-pro image, see https://github.com/goreleaser/goreleaser-cross/pkgs/container/goreleaser-cross-pro
maraino
requested changes
Dec 17, 2024
maraino
reviewed
Mar 18, 2025
maraino
reviewed
Mar 19, 2025
dopey
approved these changes
Mar 19, 2025
dopey
previously approved these changes
Mar 19, 2025
maraino
reviewed
Mar 24, 2025
Comment on lines
+103
to
+106
| env: | ||
| GORELEASER_KEY: ${{ secrets.GORELEASER_KEY }} | ||
| NFPM_PASSPHRASE: ${{ secrets.GPG_PRIVATE_KEY_PASSWORD }} | ||
| GPG_PRIVATE_KEY_FILE: ${{ env.GPG_PRIVATE_KEY_FILE }} |
Contributor
There was a problem hiding this comment.
make release is already reading the environment variables from .release-env, we should probably use only one way to set this.
Comment on lines
+147
to
+156
| -e AWS_ACCESS_KEY_ID=$(AWS_ACCESS_KEY_ID) \ | ||
| -e AWS_S3_BUCKET=$(AWS_S3_BUCKET) \ | ||
| -e AWS_S3_REGION=$(AWS_S3_REGION) \ | ||
| -e AWS_SECRET_ACCESS_KEY=$(AWS_SECRET_ACCESS_KEY) \ | ||
| -e GITHUB_TOKEN=$(GITHUB_TOKEN) \ | ||
| -e GORELEASER_KEY=$(GORELEASER_KEY) \ | ||
| -e GPG_PRIVATE_KEY_FILE=$(GPG_PRIVATE_KEY_FILE) \ | ||
| -e IS_PRERELEASE=$(IS_PRERELEASE) \ | ||
| -e NFPM_PASSPHRASE=$(NFPM_PASSPHRASE) \ | ||
| -e RELEASE_DATE=$(RELEASE_DATE) \ |
Contributor
There was a problem hiding this comment.
See the previous comment, we can add this to .release-env. Or remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for signing RPM and Deb packages and uploading them to GCP Artifact Registry. It also changes the RPM and Deb file name format to use the ConventionalFileName macro in GoReleaser.