Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request
For more information, see the
CONTRIBUTING
guide.Prerequisites
Please make sure you can check the following boxes:
Type(s) of Changes
Contribution Type
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Description
This PR contains a new feature that simplifies sharing from the app shell itself. Instead of having to configure (to be precise: this is still possible) the
shareDependencies
option increateInstance
you'll only need to add the shared modules / entry points to theshared
key in the piral.json. It will be automatically picked up and the Piral instance will have some functional exports now, too.Remarks
We still discourage this - it puts quite a large dependency on the app shell; making the pilets that use such exports only work on the given app shell.