Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added App Shell Sharing #719

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Added App Shell Sharing #719

merged 2 commits into from
Oct 9, 2024

Conversation

FlorianRappl
Copy link
Contributor

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

  • I have read the CONTRIBUTING document
  • My code follows the code style of this project
  • All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue, please reference the issue id)
  • New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Description

This PR contains a new feature that simplifies sharing from the app shell itself. Instead of having to configure (to be precise: this is still possible) the shareDependencies option in createInstance you'll only need to add the shared modules / entry points to the shared key in the piral.json. It will be automatically picked up and the Piral instance will have some functional exports now, too.

Remarks

We still discourage this - it puts quite a large dependency on the app shell; making the pilets that use such exports only work on the given app shell.

@FlorianRappl FlorianRappl added enhancement New feature or request core Concerns the piral-core library. tooling Concerns (third-party) tooling and services. labels Oct 9, 2024
@FlorianRappl FlorianRappl added this to the 1.7.0 milestone Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

File size impact

Merging feature/app-shell-shared into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 30.2 kB (0 B / +0%) 👻
Total (2) 30.2 kB (0 B / +0%) 👻
minimal-piral (no impact)
Files new size
Unmodified (2) 279 kB (0 B / +0%) 👻
Total (2) 279 kB (0 B / +0%) 👻
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.22 MB (0 B / +0%) 👻
Total (3) 2.22 MB (0 B / +0%) 👻
sample-piral (no impact)
Files new size
Unmodified (3) 699 kB (0 B / +0%) 👻
Total (3) 699 kB (0 B / +0%) 👻
sample-piral-core (no impact)
Files new size
Unmodified (3) 357 kB (0 B / +0%) 👻
Total (3) 357 kB (0 B / +0%) 👻
Generated by @jsenv/file-size-impact during check-bundle-size#11264581062 on d642b93

@FlorianRappl FlorianRappl merged commit bbbca26 into develop Oct 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Concerns the piral-core library. enhancement New feature or request tooling Concerns (third-party) tooling and services.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant