Fixes #724

[dheid]

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

• I have read the CONTRIBUTING document
• My code follows the code style of this project
• All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• Breaking change (fix or feature that would cause existing functionality to change)
• I have updated the documentation accordingly
• I have added tests to cover my changes

Description

See #724

[CLAassistant]

All committers have signed the CLA.

[github-actions]

---

Error: Error while trying to collect info before merging develop into develop.

Error: Command failed: npx lerna run build:release
lerna notice cli v8.1.7
lerna info ci enabled

    at ChildProcess.exithandler (node:child_process:422:12)
    at ChildProcess.emit (node:events:514:28)
    at maybeClose (node:internal/child_process:1105:16)
    at ChildProcess._handle.onexit (node:internal/child_process:305:5)

---

_{Generated by @jsenv/file-size-impact during check-bundle-size#11667980847 on 445bc89}

[FlorianRappl]

LGTM - maybe also consider backwards compatibility to avoid running into the original problem in other / older browsers.

[dheid]

@FlorianRappl I agreed multiple times to the contributor license, but it still says "Contributor License Agreement is not signed yet.". Do you have an idea, what I can do?

[FlorianRappl]

@FlorianRappl I agreed multiple times to the contributor license, but it still says "Contributor License Agreement is not signed yet.". Do you have an idea, what I can do?

It either may be a problem with the bot or with the settings. Keep in mind that the bot is operating on your GitHub account, so it only has access to your registered email addresses. To verify that the commits are done by you the email you entered in your local git instance is compared to the email addresses of your GitHub account. Is the email matching? If not - you may need to enter that email address in your alias list.

(I guess this might be the problem @dheid as the commit is associated with another user @eliadheid - so maybe a different email address was used in the commits?)

[dheid]

Nice! That solved the license agreement issue. Thanks!

[FlorianRappl]

Awesome - thanks again for your contribution!

There are a couple of things that should enter in 1.8.0, but in general the version should come out this week.

[dheid]

Thank you so much for accepting this PR, merging it and for the release! This bugfix will help a lot of people, I suppose. It was a really nice experience contributing to Piral. Thx!