Add some missing US Core checks now that we have attachment info #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikix
commented
Jan 9, 2025
Comment on lines
-5
to
-6
| -- CUMULUS-QUIRK | ||
| -- Doesn't look for "presentedForm", because Cumulus strips that field. |
There was a problem hiding this comment.
This was a copy-and-paste comment in error, afaict. DxReport Lab doesn't mark this field as must-support (it does mention it, but only in passing). DxReport Note does mark it as must-support, however (as seen in next file)
mikix
commented
Jan 9, 2025
| __version__ = "6.1.0" | ||
| __version__ = "7.0.0" |
There was a problem hiding this comment.
Major bump because this PR splits the previous c_us_core_v4_count DocumentReference table into two (for CUBE performance reasons), which could affect any consumers. I've also bumped the data_package_version, which I think is a correct thing to do?
mikix
force-pushed
the
mikix/docref-quirks
branch
2 times, most recently
from
3d7920a to
469d564
Compare
dogversioning
approved these changes
Jan 9, 2025
Previously, the US Core checks around DiagnosticReport.presentedForm and DocumentReference.content.attachment were marked as "quirks" that we ignored due to the ETL stripping out the bits necessary to make those checks. But now that the ETL leaves us enough info, we don't need to mark them as quirks and can just implement them. This made the DocumentReference mandatory cube too large, however, so it's now split into two tables (like Observations are). So this is a breaking change for consumers, sorry.
mikix
force-pushed
the
mikix/docref-quirks
branch
from
469d564 to
37d3d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the US Core checks around DiagnosticReport.presentedForm and DocumentReference.content.attachment were marked as "quirks" that we ignored due to the ETL stripping out the bits necessary to make those checks.
But now that the ETL leaves us enough info, we don't need to mark them as quirks and can just implement them.
This made the DocumentReference mandatory cube too large, however, so it's now split into two tables (like Observations are). So this is a breaking change for consumers, sorry.