Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add features for SMARTv2 #47

Draft
wants to merge 63 commits into
base: master
Choose a base branch
from
Draft

Add features for SMARTv2 #47

wants to merge 63 commits into from

Conversation

jmandel
Copy link
Member

@jmandel jmandel commented May 11, 2021 •
edited
Loading

I'm opening this as "draft" to start a conversation -- @vlad-ignatov what do you think about making a v2 branch to support SMART v2 WIP? I've been maintaining this outside of SMART in the early days, but as we move through the HL7 process, it'd be good to get the groundwork merged into an appropriate branch of the upstream smart-on-fhir/smart-launcher project...

BTW this branch is what's deployed for Connectathon at https://smart.argo.run/

GinoCanessa and others added 30 commits August 21, 2020 16:16
@GinoCanessa
Added ability to run in Windows.
1ca1dd7 
Added granular-scopes-app for testing.
Added link to granular-scopes-app from launcher page.
Standalone launch auth and refresh working.
@GinoCanessa
Added refresh token to refresh request.
dba5c2f
@GinoCanessa
Cleaning warnings.
a6427a9
@GinoCanessa
Improved scope handing and user information.
c39f57a 
Added dynamic loading of resource panels based on scopes.
Improved save and load of scope objects.
@GinoCanessa
Default load of resource panels with IDs working.
94bf3b0
@GinoCanessa
Refactoring scopes.
b8a38a1
@GinoCanessa
Added new scope parsing to lib.js for auth screen.
c4860e0
@GinoCanessa
Refactored common properties.
f793f8e
@GinoCanessa
Add Markdown and HTML to data panels.
853586e 
Updates to various info records to show markdown.
First cut of type-level resource display.
@GinoCanessa
Scenarios complete pass.
2e39c76
@GinoCanessa
Simple-proxy parsing graunlar scopes
67ea76d
@GinoCanessa
Pass of granular scopes pass/failing requests.
ed2cf36
@GinoCanessa
Fixed error messaging.
683bcea
@GinoCanessa
Fixed issue with multi-parameter keys.
b06046e
@GinoCanessa
Cleaning warnings.
dc22d81
@GinoCanessa
Updating deployment
03d38a2
@GinoCanessa
Updates for deployment
a7eeaa4
@GinoCanessa
Update for CI
5cf1b4b
@GinoCanessa
Hide granular launch on non-standalone launches for now
fbb8582
@jmandel
Allow env var to customize redirect URL during dev
0f6fc9e
@GinoCanessa
Merge pull request #1 from microsoft-healthcare-madison/customize-red…
82f760e 
…irect-url

Allow env var to customize redirect URL during dev
@jmandel
Label FHIR server more intuitively, I hope
aed5667
@GinoCanessa
Merge pull request #2 from microsoft-healthcare-madison/rename-aud-ui
4e1abe8 
Label FHIR server more intuitively, I hope
@GinoCanessa
Added V1 scopes for testing.
824b3ea
@jmandel
Add appId config
13272b2
@GinoCanessa
Merge pull request #3 from microsoft-healthcare-madison/add-app-id-co…
ac999b9 
…nfig

Add appId config
@GinoCanessa
Require auth during connectathon
d92539b
@GinoCanessa
Disable forced auth for connectathon - side effect of disabling the p…
0858b0b 
…atient selectors.
@GinoCanessa
Added handling for format 'patient={id}'.
9494762 
Removed 'nice' handling of duplicate scope listings.
@GinoCanessa
Added category=laboratory for testing
cabf3c8
jmandel and others added 24 commits January 8, 2021 05:17
@jmandel
Add permission-v2 capability to fix #4
a5a3e8c
@jmandel
Merge pull request #10 from microsoft-healthcare-madison/update-disco…
e617e83 
…very-v2

Add permission-v2 capability to fix #4
@jmandel
Merge branch 'master' into add-post-authorization
7092dca
@jmandel
Merge pull request #9 from microsoft-healthcare-madison/add-post-auth…
b5c7408 
…orization

Add post authorization to fix #5
@jmandel
Merge pull request #8 from microsoft-healthcare-madison/add-token-int…
422c736 
…rospection

Add token introspection to fix #7
@jmandel
Add PKCE support
f70c484
@jmandel
Exit when tests finish
0b1bf8d
@jmandel
Update test/api.js
760239a
@jmandel
Merge pull request #12 from microsoft-healthcare-madison/add-pkce-sup…
259a034 
…port

Add pkce support
@jmandel
Add code_challenge_methods_supported to dsicovery
1656636
@GinoCanessa
SMART Config and Introspection Working
f7eb438
@GinoCanessa
Introspection working.
f9b8914 
Moved client-js library into local to allow necessary changes.
@GinoCanessa
POST-based auth working.
b04676f
@GinoCanessa
Remove extra build folder.
8096dc5
@GinoCanessa
Removed module info from client-js files for production build.
6b97008
@GinoCanessa
Fixes for 'debug' error (introduced in module fixes)
66e4950
@GinoCanessa
One more 'debug' found.
badbd35
@GinoCanessa
Added 'accept' header to well-known config fetch.
e8f18fd
@GinoCanessa
Added authorization header to token introspection
c48892f
@jmandel
Update k8s for 2021 certmanager
00955dd
@jmandel
Update cluster details
25244df
@jmandel
Merge upstream
eb25c9d
@jmandel
de-duplicate introspection
5299541
@jmandel
Use CI locked deps for granular build
fbc369d
@jmandel jmandel requested a review from vlad-ignatov May 11, 2021 21:48
@vlad-ignatov
Copy link
Contributor

Yes, i see this is introducing a lot of changes and merging it properly will be difficult. In fact, I did merge it but I am also making other changes to the sandbox...

  • This project is a little outdated so I wanted to do some clean up and upgrade before introducing new features. I am doing that in branch v2, which is currently deployed to https://launch.smarthealthit.org/ (as a trail run). If people do not complain about something that is not covered by the tests, it will be merged back to master.
  • Your changes have been merged to branch v3 which is currently deployed to https://smart-launcher-staging.herokuapp.com/. Please give it a try. It was a complex merge and I may have messed up something. Note that https://smart-launcher-staging.herokuapp.com/ is for test deployments and is not guaranteed to host v3 forever.
  • I also want to switch to TypeScript (at least on the back-end) but I just don't have the time for that now with all the upcoming grant work.

I think the next step right now would be a fhirclient update. Other than the PKCE support, can you please describe what other changes you have made to it?

@jmandel
Copy link
Member Author

jmandel commented Jun 24, 2021

Thanks for taking a look! Changes include:

  • PKCE
  • Support for SMARTv2 discovery capabilities
  • Support for POST-based authorization
  • Support for token introspection with context including fhirUser and patient
  • Support for SMARTv2 style scopes like category-based Observations
  • Granular Controls demo app that demonstrates the features above

@jmandel
Copy link
Member Author

jmandel commented Jun 24, 2021

Changes still planned for SMARTv2 compatibility:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlad-ignatov vlad-ignatov Awaiting requested review from vlad-ignatov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmandel @vlad-ignatov @GinoCanessa