Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cg integrate ip1 #2

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Cg integrate ip1 #2

wants to merge 28 commits into from

Conversation

gingu
Copy link
Collaborator

@gingu gingu commented Jul 25, 2024

  • To @bparpillon @badeaa3 Let me know when is a good time for this merge. Because, before merging this branch 'cg_integrate_ip1' (which we verified it works on hardware chain of 3 PCBs,) I would like you to check/confirm that this pull request will preserve (include into main branch) all your updates in Python routines and the other two (?) submodules.
  • The tab "Files changed" above shows the merge should be OK, but I want yo also to confirm. It shows >600 files changed, but now the .gitignore is updated with the following lines:
vivado/cms_pix_28_test_firmware.cache/*
vivado/cms_pix_28_test_firmware.gen/*
vivado/cms_pix_28_test_firmware.runs/*

so all these folders, while already present in main, will not be updated

Cristinel Gingu added 28 commits June 28, 2024 18:08
…che/ip/* and vivado/cms_pix_28_test_firmware.cache/wt/*
…nabled, regardless of fw_dev_id_enable being HIGH or LOW
@badeaa3
Copy link
Collaborator

badeaa3 commented Jul 30, 2024

Hi @gingu many many thanks (and hello from Krakow, Poland). I was talking with @bparpillon about testing things. If I understood right @bparpillon verified part of it and we have more work to do then we can merge it. Let's get more comments from him

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants