fan: adopt percentage-based speeds, migrate to state-change event helper, and harden command validation #1455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mode0192
changed the title
mode0192
changed the title
…alidate device JSON This updates SmartIR’s fan platform to the current FanEntity contract, improves on/off reporting with a proper is_on property, switches to the recommended state-change event helper, and adds minimal JSON/command validation to catch common configuration issues early.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues in the SmartIR Fan component:
Fixes state restoration after Home Assistant restart by using the 'percentage' attribute instead of 'speed'.
Improves oscillation handling by only sending commands when the state changes.
Enhances power sensor integration to set a valid speed instead of None.
These changes ensure the fan's UI state matches its physical state after restarts and improve reliability with external controls.
Tested and works in my setup.