use chain_writer_utils #1388
Draft
use chain_writer_utils #1388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
product-security-plaid-production
bot
requested review from
dhaidashenko and
patricios-space
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
had a problem deploying
to
integration
GitHub Actions
Failure
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
|
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
yashnevatia
temporarily deployed
to
integration
GitHub Actions
Inactive
Unheilbar
reviewed
Nov 24, 2025
| } | ||
|
|
||
| func (c *chain) SubmitTransaction(ctx context.Context, programConfig ChainProgramConfig, contractName, method string, args any, transactionID string, toAddress string) error { | ||
| contractConfig, exists := programConfig.Programs[contractName] |
Contributor
There was a problem hiding this comment.
hmm, what's the point of accepting a map with program configs and a contract name, just to resolve program config? Why not accept config as an argument
| } | ||
|
|
||
| // Parse programs and create codec with proper encoder definitions | ||
| _, encoder, err := chainwriterutils.ParseProgramsToCodec(programConfig.Programs) |
Contributor
There was a problem hiding this comment.
Same thing here, we call one endpoint here, so we need just one encoder?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core ref: pkg-chain-submitTx
I basically moved everything out of chain_writer that submitTx uses and put it into chain_writer_utils (we can rename this).
And then i just called the implementation of the SubmitTx function from both chain.go and chain_writer.go