fix logging rate limits and add new pool scripts #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to Solana token pool ownership management and enhances the usability of CLI scripts and output formatting. The main changes are the addition of a two-step pool ownership transfer process, a new CLI command for ownership acceptance, and improved display of token rate limits.
Token Pool Ownership Management and CLI Enhancements:
Major new features and improvements:
Pool Ownership Transfer Process
ccip-lib/svm/README.md
to document a secure, two-step pool ownership transfer process, requiring both proposal by the current owner and explicit acceptance by the new owner. The documentation now includes detailed usage examples, best practices, and instructions for verifying ownership.New CLI Command
ccip-scripts/svm/pool/accept-ownership.ts
, a new CLI script that enables the proposed owner to accept token pool ownership. This script guides users through verifying their eligibility, checking balances, validating pending transfers, and finalizing the transfer, with robust error handling and user feedback.User Experience and Output Improvements
Rate Limit Display Formatting
get-chain-config
CLI output to display token rate limit values (capacity, rate, current bucket value) in both raw units and human-readable token amounts, using a new formatting helper. [1] [2]formatTokenAmount
helper method toget-chain-config.ts
to format token amounts according to their decimal precision for improved readability.These changes collectively improve the security, usability, and transparency of token pool administration and monitoring on Solana.