Configurable time before shutdown #130
Conversation
|
|
||
| To prevent missing logs after SDL shutdown, after receiving IGNITION_OFF signal SDL dumps all logs into the file system before shutdown. To control logs flushing process SDL logger has additional ini file options: | ||
|
|
||
| * Write all logs to file system before shutdown(using `LoggerImpl::Flush` function) |
There was a problem hiding this comment.
"write all logs" is misleading info, it does not guarantee all logs are written to the disk with a small maximum wait time.
There was a problem hiding this comment.
the string FlushLogMessagesBeforeShutdown in the sdl proposal is better
There was a problem hiding this comment.
I didn't quite get what you mean. Per the proposal FlushLogMessagesBeforeShutdown is Boolean, not string. Could you please clarify this?
I can suggest to change "Write all logs to file system before shutdown" to "Write logs from queue to file system before shutdown"
There was a problem hiding this comment.
I like the following from the proposal
option to flush log messages before shutdown.
option that specifies maximum time before shutdown.
There was a problem hiding this comment.
@VladSemenyuk the keyword "all" that causes the confusion, my understanding is everything in the logs will be written to disk, that is all. but it might not be the case
There was a problem hiding this comment.
@yang1070 Done
Implements #1941
This PR is not ready for review.
Risk
This PR makes no API changes.
Summary
Updates docs for #3740
CLA