Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Javarule] Updating Generic Event Trigger #524

Merged
merged 2 commits into from
Oct 9, 2023
Merged

[Javarule] Updating Generic Event Trigger #524

merged 2 commits into from
Oct 9, 2023

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Oct 6, 2023

Solves issue #523

@clinique clinique requested a review from J-N-K as a code owner October 6, 2023 07:18
@J-N-K
Copy link
Member

J-N-K commented Oct 9, 2023

Can you fix the spotless error?

@clinique
Apply spotless
51384eb 
Signed-off-by: clinique <[email protected]>
@J-N-K J-N-K added the bug Something isn't working label Oct 9, 2023
@J-N-K J-N-K added this to the 4.0.1 milestone Oct 9, 2023
J-N-K
J-N-K approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit 7942385 into smarthomej:4.0.x Oct 9, 2023
2 checks passed
@clinique clinique deleted the GenericEventTrigger branch October 9, 2023 10:31
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@clinique @J-N-K