Support FILETRANSFER #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds pieces to send file data to a device. It uses a functional core in `Jeff.Command.FileTransfer` to check each reply after a FILETRANSFER attempt to determine next steps for continuing the data transfer. The functional core allows for simpler testing
jjcarstens
commented
Feb 4, 2025
| Reply.FileTransferStatus.t() | Reply.ErrorCode.t() | ||
| def file_transfer(acu, address, data) when is_binary(data) do | ||
| with %{name: PDCAP, data: caps} <- ACU.send_command(acu, address, CAP) do | ||
| max = caps[:receive_buffer_size] || 128 |
There was a problem hiding this comment.
OSDP spec says you can send the receive_buffer_size that the reader reports from the capabilities, but I found that it doesn't work. The only size consistently finishing was using 128 bytes
LivInAbsurdism
force-pushed
the
filetransfer
branch
2 times, most recently
from
28b196d to
4990ae3
Compare
|
Handled in #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pieces to send file data to a device. It uses a functional
core in
Jeff.Command.FileTransferto check each reply after aFILETRANSFER attempt to determine next steps for continuing the data
transfer. The functional core allows for simpler testing