-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JS partons #181
Add JS partons #181
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, I just wonder - does anything about particle class need to be changed for this? Like with respect to fractional charges etc. . Is the data represented correctly?
That is a good question, I have to check this. I just tested the reading of the input file. I guess I can just test the write to file function for some of the quantities. The other ones have to be tested by hand. |
I did some further tests with the particle quantities:
I guess the charge function can be easily fixed. For the other functions it's probably more complicated. There we use the PDGID package. |
This adds now a multiplication of parton charges by a factor 3 to make them integers. This is also reflected in the documentation. There are also tests for the Particle class added for this case and I test with Jetscape to read a parton file and filter for charged partons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this looks good!
This implements the possibility to read in JETSCAPE parton output files with the Jetscape class in SPARKX. To switch to the parton mode there is a keyword argument called
particletype
in the constructor, which can be set toparton
.By default, it is set to
hadron
, such that the current behavior in any script used so far does not change.This closes #180.
The corresponding documentation is added and the CHANGELOG is updated.
I tested this with one of my current parton output files. However, I will add some more rigorous testing methods for the Jetscape class in the tests for SPARKX. This is part of #147.