Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add event plane angle return in reaction plane flow #243

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Add event plane angle return in reaction plane flow #243

merged 2 commits into from
Jul 1, 2024

Conversation

Hendrik1704
Copy link
Collaborator

This adds the return of the event plane angle in the ReactionPlaneFlow class.

This closes #239.

@Hendrik1704 Hendrik1704 added the enhancement New feature or request label Jul 1, 2024
@Hendrik1704 Hendrik1704 added this to the SPARKX 1.3 milestone Jul 1, 2024
@Hendrik1704 Hendrik1704 requested a review from NGoetz July 1, 2024 13:11
@Hendrik1704 Hendrik1704 self-assigned this Jul 1, 2024
NGoetz
NGoetz approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@NGoetz NGoetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hendrik1704 Hendrik1704 merged commit 91e595b into sparkx_devel Jul 1, 2024
1 check passed
@Hendrik1704 Hendrik1704 deleted the roch/add_sin_ReactionPlaneFlow branch July 1, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NGoetz NGoetz NGoetz approved these changes

Assignees

@Hendrik1704 Hendrik1704

Labels
enhancement New feature or request
Projects
None yet
Milestone
SPARKX 2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hendrik1704 @NGoetz