-
Notifications
You must be signed in to change notification settings - Fork 142
[DO NOT MERGE] perf(multimodal): reduce video decode, Qwen preprocess, and TokenSpeed handoff overhead #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
yechank-nvidia
wants to merge
47
commits into
smg-project:main
from
yechank-nvidia:yechan/mm-video-decode-seq
Closed
Changes from all commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
1aeb274
perf(multimodal): decode sampled video frames sequentially, not per-f…
yechank-nvidia 34023a5
perf(multimodal): reduce vision preprocessing overhead
yechank-nvidia c3e7bf2
perf(tokenspeed): optimize multimodal tensor handoff
yechank-nvidia 1557dba
fix(multimodal): address review validation gaps
yechank-nvidia bca3c04
fix(multimodal): address follow-up review gaps
yechank-nvidia 2b215d1
style(tokenspeed): apply ruff formatting
yechank-nvidia 7611aaf
test(tokenspeed): skip shm tests without torch
yechank-nvidia 7e68ea6
fix(multimodal): satisfy clippy in qwen tests
yechank-nvidia 9ce64ed
test(tokenspeed): clean shm file on failure
yechank-nvidia fb864c4
fix(tokenspeed): satisfy clippy in multimodal assembly
yechank-nvidia 2003572
fix(responses): sanitize mcp replay errors
yechank-nvidia 93683aa
Revert "fix(responses): sanitize mcp replay errors"
yechank-nvidia 32e8f70
style(multimodal): apply rustfmt
yechank-nvidia 87a09ca
fix(multimodal): address review feedback
yechank-nvidia 53e5238
style(tokenspeed): apply ruff formatting
yechank-nvidia 56a6f20
perf(multimodal): adapt OpenCV decoder threads
yechank-nvidia 41dd682
perf(multimodal): tune decoder threads across CPU quotas
yechank-nvidia 671d34f
refactor(multimodal): clarify adaptive decoder budgeting
yechank-nvidia ee5facd
perf(multimodal): reuse preprocessing worker pool
yechank-nvidia d74b216
perf(multimodal): parallelize encoder tensor serialization
yechank-nvidia 68207d9
perf(multimodal): serialize encoder tensors into mapped shm
yechank-nvidia f086ed0
perf(multimodal): skip identity bicubic resize passes
yechank-nvidia 61a3e8b
perf(multimodal): defer Qwen video normalization for TokenSpeed
yechank-nvidia 6e8466b
perf(tokenspeed): use worker vision encoder dtype
yechank-nvidia beae33f
perf(multimodal): defer Qwen image normalization
yechank-nvidia 256ee99
perf(multimodal): precompute deferred BF16 normalization
yechank-nvidia 9c44bbf
perf(multimodal): decode buffered videos without tempfiles
yechank-nvidia c36f075
fix(multimodal): propagate OpenCV probe errors
yechank-nvidia 61eab84
perf(multimodal): patchify resized Qwen video directly
yechank-nvidia 58e5a76
Overlap video decode and Qwen preprocessing
yechank-nvidia 349528e
Enable adaptive video preprocessing overlap
yechank-nvidia 5d82941
Avoid RGB conversion in streamed video preprocessing
yechank-nvidia 876f639
Remove multimodal performance environment knobs
yechank-nvidia 32a5419
Own multimodal execution resources explicitly
yechank-nvidia 4028d63
Model multimodal payload representations explicitly
yechank-nvidia b2a4935
Unify multimodal preprocessing dispatch
yechank-nvidia 3b98743
Separate multimodal backend assembly
yechank-nvidia ae75181
Separate multimodal assembly responsibilities
yechank-nvidia bdbe1fb
Isolate TokenSpeed transport policy
yechank-nvidia 19b2215
Make prepared media modality exhaustive
yechank-nvidia 5ffa5cc
Simplify multimodal assembly intermediate
yechank-nvidia 8cd337c
Generalize multimodal processor registry
yechank-nvidia 6c84189
Carry prepared media through preprocessing
yechank-nvidia 02d18b4
Use neutral multimodal assembly metadata
yechank-nvidia 4b5504a
Type multimodal preprocessing requests
yechank-nvidia 7285463
Make processor matching deterministic
yechank-nvidia d4756df
Address multimodal review findings
yechank-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| use std::env; | ||
|
|
||
| fn main() -> Result<(), Box<dyn std::error::Error>> { | ||
| println!("cargo:rerun-if-changed=src/opencv_buffer_capture.cpp"); | ||
| println!("cargo:rerun-if-env-changed=OPENCV_INCLUDE_PATHS"); | ||
| if env::var_os("CARGO_FEATURE_OPENCV_VIDEO").is_none() { | ||
| return Ok(()); | ||
| } | ||
|
|
||
| let mut build = cc::Build::new(); | ||
| build | ||
| .cpp(true) | ||
| .file("src/opencv_buffer_capture.cpp") | ||
| .flag_if_supported("-std=c++17"); | ||
|
|
||
| if let Some(paths) = env::var_os("OPENCV_INCLUDE_PATHS") { | ||
| for path in env::split_paths(&paths) { | ||
| build.include(path); | ||
| } | ||
| } else { | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| let opencv = pkg_config::Config::new() | ||
| .cargo_metadata(false) | ||
| .probe("opencv4")?; | ||
| for path in opencv.include_paths { | ||
| build.include(path); | ||
| } | ||
| } | ||
|
|
||
| build.compile("smg_opencv_buffer_capture"); | ||
| Ok(()) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.