Repository navigation
build(deps): llm-tokenizer's toml entry in Cargo.lock names the locked 1.1.6 - #2835
Merged
Merged
Conversation
…d 1.1.6 #2829 moved toml to 1.1.6, and #2817, merged after it, added toml to llm-tokenizer's dev-dependencies with the lock entry still naming 1.1.5, which the lock no longer holds. Any --locked build of main fails (cargo metadata --locked exits 101); with the entry naming 1.1.6 it passes. Signed-off-by: Alex McC <319643551+hello-alexmcc@users.noreply.github.com>
hello-alexmcc
requested review from
CatherineSue,
key4ng and
slin1237
as code owners
October 7, 2026 02:32
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
3 of 4 tasks
slin1237
added a commit
that referenced
this pull request
Oct 7, 2026
Brings the three commits main gained since eda1134 (#2835 Cargo.lock's toml entry, #2833 the tagged discovery config with one runtime conversion, #2838 Qwen3's tagged call syntax) under the leap branch. Resolutions, both import lists: - model_gateway/src/config/builder.rs: the `crate::config` import takes main's `KubernetesDiscoveryConfig` and the leap's `KvIndexKind`, in rustfmt order. - model_gateway/src/main.rs: the same pair in the same list. Cargo.lock, bindings/python/src/lib.rs, config/types.rs and config/validation.rs merged on their own; the bindings build the discovery config in main's enum form and the runtime conversion is main's. Signed-off-by: Simo Lin <25425177+slin1237@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem
main's
Cargo.lockfails--locked:cargo metadata --lockedexits 101. #2829 movedtomlto 1.1.6. #2817, merged after it, addedtomlto llm-tokenizer's dev-dependencies, and its lock entry still namestoml 1.1.5+spec-1.1.0, which the lock no longer holds. A build without--lockedsilently rewrites the lock, so CI does not see it.Solution
llm-tokenizer's dependency entry names the locked
toml 1.1.6+spec-1.1.0.Changes
Cargo.lock: one line.Test Plan
cargo +1.98.0 metadata --locked --format-version 1exits 101.toml 1.1.5entry is left.Checklist
cargo +nightly fmtpassescargo clippy --all-targets --all-features -- -D warningspasses