Fix decodeFile Null Crash #556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lesDir(). Adds a fallback to internal storage for rare cases.
… cannot be loaded.
jumaallan
requested changes
Feb 26, 2025
| fileSavePath = context.getDir("SmileID", MODE_PRIVATE).absolutePath | ||
| // Primary: /storage/emulated/0/Android/data/<package name>/files/SmileID | ||
| // Fallback: /data/user/0/<package name>/app_SmileID | ||
| fileSavePath = context.getExternalFilesDir("SmileID")?.absolutePath |
There was a problem hiding this comment.
the fallback will never work fyi
this is because the app data is always available. you need to change this to implementation to see if the externalFileDir is available, then use it (this will be an api check I believe), then use it otherwise use the primary implementation
…e confirmation dialog as opposed to reading from file.
…model before showing image confirmation.
robin-smileid
requested changes
Mar 6, 2025
lib/src/main/java/com/smileidentity/viewmodel/SelfieViewModel.kt
Outdated
Show resolved
Hide resolved
robin-smileid
previously approved these changes
Mar 6, 2025
There was a problem hiding this comment.
Code changes look fine to me. Tested and works on my SM M21. Great work @tobitech
| SmileIDCrashReporting.hub.captureException(e) | ||
| onError(e) |
There was a problem hiding this comment.
@jumaallan I think we might have deleted the onError by accident? We should likely keep it to trigger the error screen.
JNdhlovu
requested changes
Mar 18, 2025
| try { | ||
| BitmapPainter(BitmapFactory.decodeFile(path).asImageBitmap()) | ||
| BitmapFactory.decodeFile(path)?.let { bitmap: Bitmap -> |
There was a problem hiding this comment.
I think as long as we don't sample this bitmap this will always crash with OOM
- We don't need a high quality image for display
- This may also need to be done async as well
| ) | ||
| } | ||
| // when { | ||
| // showInstructions && !acknowledgedInstructions -> SmartSelfieInstructionsScreen( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://app.shortcut.com/smileid/story/15206
Summary
Known Issues
N/A.
Test Instructions
selfieToConfirmto null before the check for file validity inSelfieViewModel.kt.Screenshot
N/A