-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata Network Connection #306
base: fraud-signals-metadata
Are you sure you want to change the base?
Conversation
Generated by 🚫 Danger Swift against 5fce76d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please address the formatting suggestion.
- Let's make the network connection an array and recording it from init till submission and record any changes as discussed in our call today
- I'm getting the following error at the moment:
Otherwise it looks good. Thanks @tobitech .
…leton manager that can register dynamic and static metadata provider instead of an object whose instance is created multiple times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor changes. I'll approve since it looks fine and those aren't blockers, but please attend if you think it make sense to change those. Tested the flow on the selfie capture and it adds the network changes as expected.
Sources/SmileID/Classes/BiometricKYC/OrchestratedBiometricKycViewModel.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Did a test on Selfie enrollment and it works fine with the new metadata field being added.
Story: https://app.shortcut.com/smileid/story/15152/
Summary
Known Issues
I'm exploring how to make the code easier to follow and trace for other people reading the codeTest Instructions
Screenshot
N/A.