Restricted mods #872
Open
Restricted mods #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| internal long numPossibleProteoforms(List<Modification> allKnownFixedModifications, | ||
| DigestionParams digestionParams, List<Modification> variableModifications) | ||
|
|
There was a problem hiding this comment.
Instead of taking digestion params, it can just take an int paramater called "MaxNumberOfModifiedSites". DigestionParams.MaxModsForPeptide() and DigestionParams.MaxMods are equal
| } | ||
| } | ||
|
|
||
| internal long numPossibleProteoforms(List<Modification> allKnownFixedModifications, |
There was a problem hiding this comment.
This feels like it will be the entry point. This method should be public and well commented
|
Added new commit! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #872 +/- ##
==========================================
+ Coverage 78.28% 78.31% +0.02%
==========================================
Files 244 244
Lines 35726 35769 +43
Branches 3761 3766 +5
==========================================
+ Hits 27969 28012 +43
Misses 7123 7123
Partials 634 634
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation-less (in protein, probably) method of generating the number of possible proteoforms given a max number of residue sites. Draft mostly because it's untested.