Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a bug that checked BAM things even when not compiled with HTS support #63

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fixing a bug that checked BAM things even when not compiled with HTS support #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/falco.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,11 +77,12 @@ read_stream_into_stats(T &in, FastqStats &stats, FalcoConfig &falco_config) {
size_t file_size = in.load();
size_t tot_bytes_read = 0;

// can't report progress for bam files
constexpr bool is_bam = std::is_same<T, BamReader>::value;

// decide whether to report progress
const bool quiet = falco_config.quiet || is_bam;
const bool quiet = falco_config.quiet
#ifdef USE_HTS
|| std::is_same<T, BamReader>::value // can't do progress for bam
#endif
;

ProgressBar progress(file_size, "running falco");
if (!quiet)
Expand Down
Loading