Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teambuilder: Debounce searching teams #2270

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Teambuilder: Debounce searching teams #2270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa6190b
Teambuilder: Debounce searching teams
PartMan7 Jul 27, 2024
1fb295f
Teambuilder: Only debounce for 500+ teams
PartMan7 Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions play.pokemonshowdown.com/js/client-teambuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,8 @@
curFolder: '',
curFolderKeep: '',
curSearchVal: '',
// Debounce value for searching in the teambuilder
searchTimeout: null,

exportMode: false,
formatResources: {},
Expand Down Expand Up @@ -3239,11 +3241,24 @@
this.chartSet(val, selectNext);
},
searchChange: function (e) {
// 91 for right CMD / 93 for left CMD / 17 for CTL
if (e.keyCode !== 91 && e.keyCode !== 93 && e.keyCode !== 17) {
this.curSearchVal = e.currentTarget.value;
var DEBOUNCE_THRESHOLD_TEAMS = 500;
function updateTeamList() {
// 91 for right CMD / 93 for left CMD / 17 for CTL
if (e.keyCode !== 91 && e.keyCode !== 93 && e.keyCode !== 17) {
this.curSearchVal = searchVal;
}
this.updateTeamList();
}

// If the user has a lot of teams, search is debounced to
// ensure this isn't called too frequently while typing
if (Storage.teams.length > DEBOUNCE_THRESHOLD_TEAMS) {
if (this.searchTimeout) clearTimeout(this.searchTimeout);

var searchVal = e.currentTarget.value;
this.searchTimeout = setTimeout(updateTeamList.bind(this), 400);
} else updateTeamList();

},
chartSetCustom: function (val) {
val = toID(val);
Expand Down
Loading