Display exact HP when using Exact HP Mod #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3442,6 +3444,7 @@ export class Battle { | |||
| this.messageFadeTime = 40; | |||
| this.isBlitz = true; | |||
| } | |||
| if (ruleName === 'Exact HP Mod') this.reportExactHP = true; | |||
There was a problem hiding this comment.
why are you making a new property instead of checking this.rules['Exact HP Mod']
There was a problem hiding this comment.
was primarily was looking at something else was implemented and decided to mirror, if it should be checked that way then sure
There was a problem hiding this comment.
I left blitz and species clause when I added the rules object just to minimize refactoring at the time, but I think any new code that needs rules should just use the rules object if the only thing that needs to be checked is if the rule is in play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exact HP mod sends current HP and Max HP to both the user and the opponent via server protocol messages, but displays percent regardless unless the user turns on hardcore mode, making it information almost only accessible via the console. This pull request displays the current hp in the hp bar and the current and Max HP in the pokemon's tooltips for easier accessibility.
Before:
https://github.com/user-attachments/assets/606f60bc-a4ee-4666-9144-c5432f517855
After:
https://github.com/user-attachments/assets/d103e177-005f-4132-a425-0d14e49a2008