Fixed a case of endless loop #2285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Team packing originally seemed like a great idea, since teams should be able to be efficiently stored in However, newer gens have released all sorts of new mechanics that mess with teams formats. Additionally, there has been some developments in data compression, such as:
You can probably bring this discussion to the Smogon Development Discord server. |
shrianshChari
pushed a commit
to shrianshChari/pokemon-showdown-client
that referenced
this pull request
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was possible to freeze the tab by importing a team/set containing
]with no|after.(only if the whole import is 1 line or 2 lines with the 2nd one being blank - this leads to the importer using
Storage.unpackTeam()which is intended functionality.)I took care to not conflict with #2222 . hopefully we can discuss rewriting the packed team format after these prs are resolved ...
credit for finding this bug: #2283 (comment)