-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All the changes contained in this version are listed in the PR specification #85
Draft
smoia
wants to merge
93
commits into
master
Choose a base branch
from
ref/refactoring
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoia
added
Minormod-breaking
For development only, this PR increments the minor version (0.+1.0) but breaks compatibility
Refactoring
Improve nonfunctional attributes and bump up a minor version (0.+1.0)
labels
Mar 9, 2023
smoia
force-pushed
the
master
branch
2 times, most recently
from
August 12, 2023 14:18
2f6f43f
to
884ba21
Compare
smoia
force-pushed
the
ref/refactoring
branch
from
September 8, 2023 16:55
1569d79
to
6f2e1c6
Compare
smoia
changed the title
Swap loops for sliding window views and refactor code to imrpove clarity and performance.
All the changes contained in this version are listed in the PR specification
Nov 22, 2023
smoia
added
the
Majormod
This PR breaks compatibility, and increments the major version (+1.0.0)
label
Nov 24, 2023
…reated from masks)
…orr related steps
for more information, see https://pre-commit.ci
…al resample_signal to improve clarity.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…reated from masks)
This reverts commit 25f557f.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Majormod
This PR breaks compatibility, and increments the major version (+1.0.0)
Minormod-breaking
For development only, this PR increments the minor version (0.+1.0) but breaks compatibility
Refactoring
Improve nonfunctional attributes and bump up a minor version (0.+1.0)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
The main change of this PR is that the loops that could be switched for sliding windows views have been switched to improve performance. This, however, breaks backward compatibility, and forces the adoption of numpy > 1.20, with all that comes from it.
For the rest, this PR makes small improvements to different parts of code.
It's mainly about refactoring different parts of the code that became repetitive or useless, but it also fixes some minor "oversight" of previous PRs.
Proposed Changes
numpy
version to be equal or higher than 1.20.0get_*
functions intocreate_*
.stats
now contains only statistical models (OLS, Xcorr, and related), while a new moduleregressors
contains all functions to create regressors and related operations (e.g. bulk shift and fine shift estimation).resample_signal
now uses the number of interpolated samples to resample the signals, rather than asking for frequencies.resample_signal
is nowresample_signal_freqs
.convolve_petco2
is nowcompute_petco2hrf
to better reflect what the code does.skip_conv
flag is nowskip-petco2hrf
,run_conv
is nowrun_petco2hrf
.get_regr
in the parts related to cross correlation.export_regressor
so that it works with ND arrays.brightspin-clinical
configuration now skips bulk shift estimation (cross correlation).Change Type
bugfix
(+0.0.1)minor
(+0.1.0)major
(+1.0.0)refactoring
(no version update)test
(no version update)infrastructure
(no version update)documentation
(no version update)other
Checklist before review