fix(pack): harden asset archive extraction - #306
Open
kgarg2468 wants to merge 1 commit into
Open
Conversation
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit 5c4a0e4 on May 27, 2026 9:06pm UTC. |
BinSquare
requested changes
May 27, 2026
BinSquare
left a comment
BinSquare
left a comment
Contributor
There was a problem hiding this comment.
looks good, requesting for slight expansion of test coverage + nits
| ); | ||
| } | ||
|
|
||
| #[test] |
Contributor
There was a problem hiding this comment.
it's unclear what this specific part is doing? What is the filesystem breakout scenario?
| } | ||
|
|
||
| #[test] | ||
| fn test_decompress_assets_extracts_regular_files() { |
Contributor
There was a problem hiding this comment.
a normal pack is extracting regular files so this test is unnecessary
| Ok(0) // Entire file is zeros | ||
| } | ||
|
|
||
| fn validate_archive_path(path: &Path) -> Result<()> { |
Contributor
There was a problem hiding this comment.
would want test in particular for this specific functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation