[DO NOT MERGE] Allow a type implementing phy::Device to contain borrowed data#697
Closed
ebarnard wants to merge 2 commits intosmoltcp-rs:masterfrom
Closed
[DO NOT MERGE] Allow a type implementing phy::Device to contain borrowed data#697ebarnard wants to merge 2 commits intosmoltcp-rs:masterfrom
phy::Device to contain borrowed data#697ebarnard wants to merge 2 commits intosmoltcp-rs:masterfrom
Conversation
ebarnard
changed the title
phy::Device to contain borrowed dataphy::Device to contain borrowed data
Contributor
Author
|
This is not yet ready to merge. It requires GATs in stable which is set to be released in Rust 1.65 on 3rd Nov. |
ebarnard
force-pushed
the
device-gats
branch
2 times, most recently
from
bb0b614 to
8da5806
Compare
Previously, a limitation of Rust's type system required a device to implement `phy::Device<'a>` for all lifetimes, including `'static`, to be able to call methods on `iface::Interface`. This prevented types implementing `phy::Device<'a>` from containing any borrowed data. Now that Rust supports GATs (generic associated types), it is possible to lift this restriction and allow implementations of `phy::Device<'a>` which contain borrowed data.
Contributor
|
I haven't checked the code diffs, but this sounds similar to #572 ? |
Contributor
Author
|
It's exactly the same. I even looked at the list of open PRs before starting this. Oh well. Closing in favour of the existing #572. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a limitation of Rust's type system required a device to
implement
phy::Device<'a>for all lifetimes, including'static, tobe able to call methods on
iface::Interface. This prevented typesimplementing
phy::Device<'a>from containing any borrowed data.Now that Rust supports GATs (generic associated types), it is possible
to lift this restriction and allow implementations of
phy::Device<'a>which contain borrowed data.