Fix UnicodeDecodeError when loading know-how docs on Windows#286
Open
aevo98765 wants to merge 1 commit intosnap-stanford:mainfrom
Open
Fix UnicodeDecodeError when loading know-how docs on Windows#286aevo98765 wants to merge 1 commit intosnap-stanford:mainfrom
aevo98765 wants to merge 1 commit intosnap-stanford:mainfrom
Conversation
On Windows, open() defaults to cp1252 encoding which fails to decode UTF-8 characters in the know-how markdown files. Explicitly specifying encoding="utf-8" fixes the crash for Windows users.
aevo98765
force-pushed
the
fix/windows-utf8-encoding-knowhow
branch
from
9641551 to
36739a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, open() defaults to cp1252 encoding which fails to decode UTF-8 characters in the know-how markdown files. Explicitly specifying encoding="utf-8" fixes the crash for Windows users.