Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Remove executable bit from logfiles #2038

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

chr4
Copy link

@chr4 chr4 commented Feb 15, 2022

Changes file mode for openwb.conf and openWB.log from 777 to 666.

Logfiles should never be executable. I don't think this should have any impact, as they are hopefully never executed.

It would be advisable to also not have them world writeable, I'll look into that as well.

@hhoefling
Copy link
Contributor

Deine Änderung reicht nut bis zum nächsten reboot.
Die 777 sind gut verstreut im Quellbaum.
Da muss gründlicher vorgegangen werden.

( Ich würd's lassen. auf meinen Openwb kommt nur wasser&CD, was soll da passieren. :-) )

@chr4 chr4 force-pushed the patch-1 branch 2 times, most recently from eae744b to 6ff3750 Compare February 15, 2022 19:55
@hhoefling
Copy link
Contributor

hhoefling commented Feb 15, 2022

Ok, aber pass auf die Order auf.
Ordner brauchen das X Bit..

@hhoefling
Copy link
Contributor

hhoefling commented Feb 15, 2022

Gerade -R z.b. bei
sudo chmod -R 666 /var/www/html/openWB/web/logging/data/
ist höchst gefährlich.

chr4 added 2 commits February 15, 2022 22:37
Logfiles should never be executable. I don't think this should have any
impact, as they are hopefully never executed.
@chr4
Copy link
Author

chr4 commented Feb 15, 2022

Jo, geht mehr um best-practise gebe ich zu.

Ich denke ich hab alle erwischt, X sollte +x automatisch bei Verzeichnissen setzen.

ramdisk und ramdisk/ sollte nen duplicate sein. Ich hab es mal entfernt.

@hhoefling
Copy link
Contributor

Auch möglich das da ein * am ende fehlt.

also
sudo chmod ugo=rwX /var/www/html/openWB/ramdisk/*
mach schon sinn.

@chr4
Copy link
Author

chr4 commented Feb 16, 2022

Gleiches für modules/. Gibt einige duplicates und ich denke oft wäre -R sauberer als /*. Allerdings hast du vielleicht recht und es macht kaum Sinn sich da durchzuwühlen, insb. wenn https://github.com/openWB/core in mache ist...

@chr4 chr4 changed the title Remove executable bit from logfiles Draft: Remove executable bit from logfiles Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants