forked from scroll-tech/scroll-prover
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate Sirius folding #1
Open
cyphersnake
wants to merge
6
commits into
main
Choose a base branch
from
sirius-folding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+797
−796
Open
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9216b2f
add modified zkevm-circuits dependency
chaosma 2471474
add fold_tests file
chaosma 8d122e5
remove print log
chaosma 7d117f4
chore: bump sirius version
cyphersnake a8fa97a
chore: upd toolchain
cyphersnake c22e1d4
fix: `trie` crate version in Cargo.lock
cyphersnake File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
use integration::test_util::load_chunk_for_test; | ||
use prover::{ | ||
fold::Prover, | ||
utils::init_env_and_log, | ||
zkevm::circuit::SuperCircuit, | ||
}; | ||
|
||
#[cfg(feature = "prove_verify")] | ||
#[test] | ||
fn test_fold_prove() { | ||
let test_name = "fold_tests"; | ||
let output_dir = init_env_and_log(test_name); | ||
log::info!("Initialized ENV and created output-dir {output_dir}"); | ||
|
||
let chunk_trace = load_chunk_for_test().1; | ||
log::info!("Loaded chunk trace"); | ||
|
||
//let mut prover = Prover::<SuperCircuit>::from_params_dir(PARAMS_DIR); | ||
let mut prover = Prover::<SuperCircuit>::default(); | ||
|
||
prover.fold("fold", chunk_trace).unwrap(); | ||
log::info!("finish folding"); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
nightly-2023-12-03 | ||
nightly-2024-07-30 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. NBD: we can still use the old-version to be compatible with scroll's branch |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if remove above two patches and the code still run, then we don't need to add them