conf: fix validating service parents (fixes #1376)

sni · Jul 19, 2024 · aac1a07 · aac1a07
1 parent 52f3dc1
commit aac1a07
Showing 1 changed file with 18 additions and 0 deletions.
diff --git a/plugins/plugins-available/conf/lib/Monitoring/Config.pm b/plugins/plugins-available/conf/lib/Monitoring/Config.pm
@@ -2226,6 +2226,24 @@ sub _check_references {
                     return if $tst =~ m/$newval/;
                     ## use critic
                 }
+            } elsif($attr eq 'parents' && $link eq 'service') {
+                if($val =~ m/,/mx) {
+                    my @list = split(/\s*,\s*/mx, $val);
+                    my $failed;
+                    while(scalar @list > 0) {
+                        my $hst = shift @list;
+                        my $svc = shift @list;
+                        if(!defined $hst || !$objects_by_name->{'host'}->{$hst}) {
+                            $failed = 1;
+                            last;
+                        }
+                        if(!defined $svc || !$objects_by_name->{'service'}->{$svc}) {
+                            $failed = 1;
+                            last;
+                        }
+                    }
+                    return if !$failed;
+                }
             }
 
             if($options{'hash'}) {