Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importer front-end improvements (minimum mapping, no dupes) #16114

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

uberbrady
Copy link
Collaborator

The UI here is not very good, but I think the basics of how this might work are relatively solid.

This requires that a certain, minimum set of fields need to be mapped before you're allowed to continue with the import.

While I was at it, I thought I would detect for when users try and map two different CSV columns to the same field - which doesn't really make much sense.

But, as I mentioned, the actual look-and-feel here is pretty terrible, and needs some work. I'm not even sure I like the 'you can't hit submit button until you fix your problems' UI either - it's not very intuitive.

Copy link

what-the-diff bot commented Jan 22, 2025

PR Summary

  • Enhanced Data Import Capabilities:

    • New features have been added to track any duplicate mappings and ensure that data meets certain requirements before initiating import. For instance, a new property is introduced to track mapping errors, while another property indicates if there's enough data to proceed with the import.
    • Two new methods have been introduced. One is used to validate and set mapping errors while the other checks if there are enough mapped fields depending upon the type of import.
  • Improved Logging Mechanisms:

    • Additional logging has been integrated into the import process, making it easier to trace and troubleshoot any issues that might crop up.
  • Refined Field Name Consistency:

    • Certain field names have been updated for better consistency. Most notably, 'qty' has been changed to 'quantity' across various fields. This update will bring unity to the naming convention in use.
  • Updated Visual Layout:

    • Changes have been made in the user interface to improve visuals and usability. The column widths in the display template have been adjusted, a new column displaying mapping errors has been added. Furthermore, the 'import' button's state is now reliant on whether there's enough data to be imported, enhancing user approachability to actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant