Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds qr code type check in getQRCode method #16167

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

Godmartinz
Copy link
Collaborator

This adds a check in the Assets controller that the qrcode type selected is not none.

@Godmartinz Godmartinz requested a review from snipe as a code owner February 3, 2025 18:40
@Godmartinz Godmartinz requested review from marcusmoore and removed request for snipe February 3, 2025 18:40
Copy link

what-the-diff bot commented Feb 3, 2025

PR Summary

  • Enhancement in QR code generation process
    The method that creates QR codes for our application has been enhanced. Previously, it only generated a QR code if a certain setting was enabled. With this update, an additional condition has been introduced, ensuring the QR code is only created when a specific type of label is active. This increases efficiency and prevents unnecessary processes when the data type for the label does not require a QR code.

@marcusmoore marcusmoore requested a review from snipe February 3, 2025 18:48
@snipe snipe merged commit b195168 into snipe:develop Feb 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants