Skip to content

Conversation

@GustavoBitten
Copy link

@GustavoBitten GustavoBitten commented Aug 2, 2024

  • New Logic for Divided Laps: Added functionality to record and save half laps, providing more detailed tracking of progress.
  • Improved Lap Saving Logic: Refined the process of saving laps, making it clearer and more intuitive.
  • New Graph Tool: Able to scroll and drag better

@GustavoBitten GustavoBitten changed the title wip Enhancements and New Features Aug 2, 2024
@snipem
Copy link
Owner

snipem commented Aug 22, 2024

Thanks for your contribution. I will look into it!

Copy link
Owner

@snipem snipem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First part of my review

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file look wrong, please delete

# Update breakpoints
# Adding Brake Points is slow when rendering, this is on Bokehs side about 3s
brake_points_enabled = os.environ.get("GT7_ADD_BRAKEPOINTS") == "true"
brake_points_enabled = True
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't overwrite the outcome of the environment variable

from gt7dashboard.gt7lap import Lap

PLAYSTATION_IP = "ps5wifi"
PLAYSTATION_IP = "192.168.15.96"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should find a solution that works for both of us. In the mean time, please do not change the IP.

@@ -0,0 +1,140 @@
from datetime import timedelta
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this is just reorganised to a different file?

height=250,
tooltips=tooltips,
active_drag="box_zoom",
active_drag="auto"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change in behaviour?




def divide_laps(old_data: GTData, new_data: GTData):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do? I do not understand the whole logic behind device_laps and equalizer_lap. Please describe in the comment of the functions. Can you give a screenshot or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants