-
Notifications
You must be signed in to change notification settings - Fork 55
Enhancements and New Features #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution. I will look into it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First part of my review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file look wrong, please delete
| # Update breakpoints | ||
| # Adding Brake Points is slow when rendering, this is on Bokehs side about 3s | ||
| brake_points_enabled = os.environ.get("GT7_ADD_BRAKEPOINTS") == "true" | ||
| brake_points_enabled = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't overwrite the outcome of the environment variable
| from gt7dashboard.gt7lap import Lap | ||
|
|
||
| PLAYSTATION_IP = "ps5wifi" | ||
| PLAYSTATION_IP = "192.168.15.96" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should find a solution that works for both of us. In the mean time, please do not change the IP.
| @@ -0,0 +1,140 @@ | |||
| from datetime import timedelta | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect this is just reorganised to a different file?
| height=250, | ||
| tooltips=tooltips, | ||
| active_drag="box_zoom", | ||
| active_drag="auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this change in behaviour?
|
|
||
|
|
||
|
|
||
| def divide_laps(old_data: GTData, new_data: GTData): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? I do not understand the whole logic behind device_laps and equalizer_lap. Please describe in the comment of the functions. Can you give a screenshot or something?
Uh oh!
There was an error while loading. Please reload this page.