Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from Kosinkadink:main #21

Open
wants to merge 280 commits into
base: main
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented May 21, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

@pull pull bot added ⤵️ pull merge-conflict Resolve conflicts manually labels May 22, 2024
Kosinkadink and others added 28 commits June 17, 2024 01:13
…al and max_float_val, fixed Multival Dynamic throwing error if float_val list length less than mask length, simplified linear_conversion function
…a PIA Input [Paper Presets], some prototype work on PIA effect_multival input (hidden for now)
…al Expansion

PIA, Image Injection, and Multival Expansion
Made lora hook patches work for newest ComfyUI
Implements a new ADEWARN widget which displays red warning text on a
node. Nodes which have an ADEWARN widget are hidden from the searchbox
Added color option to set the color of the warning text

When the warning text is an empty string, the widget has 0 height,
effectively hiding it.

Added a warn type as well as options for including nodes of type
'deprecated' or 'experimental' in search anyways. If a widget does not
have an assigned type, it defaults to deprecated.

Actually fix nodes being hidden on refresh. The last attempt was merely
nothing ever being hidden because of a syntax error preventing teh
script from loading. This implementation takes the rather more heavy
handed approach of applying at beforeRegisterNodeDef and setting up the
global filter option at init. This makes it marginally more likely to
interfere with other plugins that attempt to modify app.graph.filter, so
added safety has been included elsewhere in the code.

Added example usage to to Inject PIA as to demonstrate how it might be
used for an experimental node.
Implement a deprecation widget which also hides nodes from the search box
Made use of deprecated/experimental .js features, made settings menu …
The workaround for filter being overwritten by applying to late for
refreshComboInNodes was to apply the filter with beforeRegisterNodeDef,
but that doesn't apply no js nodes inverted the issue of nodes being
hidden. A setup call has been added to ensure js nodes have the default
filter applied
Fix js nodes not having filter applied.
…h, allowing that patch to not be overridden when using Custom CFG (some stuff might fail if it expects cond_scale to be a float instead of a tensor)
Kosinkadink and others added 30 commits December 26, 2024 07:41
… but after some more testing with the diffusers repo, it does not seem like something that can be extended well. Will continue to explore
…rame, small refactoring to make this possible, fully deprecated AnimateDiff Loader [Legacy] node
… CameraCtrl Pose speed; still need to fix CameraCtrl Poses not adding to each other as expected
…s multiple nodes/calls, removed conditioning.py since most of the code there was already deprecated in favor of vanilla ComfyUI after my PR was merged in early December
…anced-ControlNet (DinkLink versioning coming in clutch)
Backend changes + fixes
…mple_sigmas" to match up with incoming ComfyUI PR
Fix backwards compatibility of fixed KF scheduling code
- Add permissions for issue writing
- Update action version to v1 for publish-node-action
- Add condition to run job only for 'Kosinkadink' repository owner
Make CustomCFGKeyframe's effective_guarantee_steps check handle start…
Add normalized weighted sum noise layer
Update Github Action for Publishing to Comfy Registry
…ed for the additional noise generated by ancestral samplers
Add Ancestral Options to control ancestral sampler noise
Fix RuntimeError: Float did not match Long when ComfyUI is outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⤵️ pull merge-conflict Resolve conflicts manually
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants