Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history 
commit eb427bb
Author: Yoland Yan <[email protected]>
Date:   Thu Jul 11 17:15:45 2024 -0700

    Add comfy run flags field (Comfy-Org#73)

    * Add comfy run flags field

    * Regenerate.

    * Fixed.

    ---------

    Co-authored-by: Robin Huang <[email protected]>

commit a62fbdc
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 17:02:04 2024 -0700

    Add machine name, pytorch version, cuda version, job id fields. (Comfy-Org#72)

    * Add machine name.

    * Added tests./

commit 90f8b54
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 15:58:59 2024 -0700

    Added API: Get single workflow result + Bugfix (Comfy-Org#71)

    * Added API: Get single workflow result

    * Add assert for id field.

    * Fix bug for no storage file.

    * Bug fix.

commit 201f58f
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 14:21:02 2024 -0700

    Update checksum for migrations.

commit 0202b10
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 14:12:40 2024 -0700

    Ignore nil values for metadata column.

commit af697a5
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 14:12:27 2024 -0700

    Set null values to default before alter table.

commit bc0f36f
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 11:21:26 2024 -0700

    Add additional machine spec fields. (Comfy-Org#70)

commit b74c609
Author: Robin Huang <[email protected]>
Date:   Thu Jul 11 09:57:14 2024 -0700

    Allow storing multiple output files per workflow. (Comfy-Org#69)

    * Allow multiple storage files per workflow result.

    * Add migration.

commit 0275efb
Author: Robin Huang <[email protected]>
Date:   Wed Jul 10 18:38:32 2024 -0700

    Delete existing workflow results with the same OS, workflow name and commit. (Comfy-Org#68)

commit b9f22d8
Author: Robin Huang <[email protected]>
Date:   Wed Jul 10 18:29:34 2024 -0700

    Add VRAM, job trigger user, and other fields for CI workflow results. (Comfy-Org#67)

    * Remove unused variable.

    * Add vram, status, and other values.

commit 69a3bf1
Author: James Kwon <[email protected]>
Date:   Tue Jul 9 11:52:50 2024 -0400

    Refactor integration test (Comfy-Org#66)

    Co-authored-by: James Kwon <[email protected]>

commit e4671e2
Author: James Kwon <[email protected]>
Date:   Mon Jul 8 13:05:18 2024 -0400

    Improve Registry Endpoint Client Side Error (Comfy-Org#65)

    Co-authored-by: James Kwon <[email protected]>

commit be76018
Author: James Kwon <[email protected]>
Date:   Mon Jul 8 12:59:33 2024 -0400

    Add service account middleware authentication (Comfy-Org#64)

    Co-authored-by: James Kwon <[email protected]>

commit 7b5c79a
Author: James Kwon <[email protected]>
Date:   Fri Jul 5 21:34:03 2024 -0400

    add service account middleware (Comfy-Org#63)

commit 43e2493
Author: James Kwon <[email protected]>
Date:   Thu Jul 4 22:45:15 2024 -0400

    Improve the listAllNodes endpoint with retrieving latest version with the node retrieval. (Comfy-Org#62)

    * fix node version

    * fix node version

commit 6fd8b9c
Author: James Kwon <[email protected]>
Date:   Thu Jul 4 20:38:48 2024 -0400

    Algolia enhance (Comfy-Org#61)

commit 6e68daf
Author: Robin Huang <[email protected]>
Date:   Thu Jul 4 17:25:53 2024 -0700

    Update to algolia secret version 2.

commit ffd539b
Author: James Kwon <[email protected]>
Date:   Tue Jul 2 14:17:20 2024 -0400

    Revert "Make slight optimization on listAllNodes endpoint (Comfy-Org#55)"

    This reverts commit bb3d04b.

commit 76c4b46
Author: James Kwon <[email protected]>
Date:   Tue Jul 2 07:56:50 2024 -0400

    Algolia enhance (Comfy-Org#60)

commit 4442639
Author: James Kwon <[email protected]>
Date:   Sun Jun 30 22:03:28 2024 -0400

    Remove authentication for reindex endpoint (Comfy-Org#59)

    Co-authored-by: James Kwon <[email protected]>

commit b2882fc
Author: James Kwon <[email protected]>
Date:   Thu Jun 27 23:12:16 2024 -0400

    add max nodes (Comfy-Org#57)

commit 382093b
Author: James Kwon <[email protected]>
Date:   Thu Jun 27 20:53:51 2024 -0400

    convert reindex job as api (Comfy-Org#56)

commit bb3d04b
Author: James Kwon <[email protected]>
Date:   Thu Jun 27 20:48:44 2024 -0400

    Make slight optimization on listAllNodes endpoint (Comfy-Org#55)

    * don't re fetch latest version

    * don't re fetch latest version

    * don't re fetch latest version

commit 36d2f00
Author: James Kwon <[email protected]>
Date:   Wed Jun 26 23:24:07 2024 -0400

    test scan node (Comfy-Org#54)

commit dac19f2
Author: Robin Huang <[email protected]>
Date:   Mon Jun 24 10:08:09 2024 -0700

    Increase scanned nodes to 10 from 5.

commit 1fa4dcf
Author: James Kwon <[email protected]>
Date:   Mon Jun 24 12:13:59 2024 -0400

    Implement Agolia Search Indexing Capabilitiy (Comfy-Org#53)

    * Algolia search

    * Algolia search

    * additional fix

    ---------

    Co-authored-by: James Kwon <[email protected]>

commit 7c6df74
Author: Robin Huang <[email protected]>
Date:   Sat Jun 22 17:09:43 2024 -0700

    Add discord channel webhook config.

commit 9b19fcb
Author: Robin Huang <[email protected]>
Date:   Sat Jun 22 16:40:53 2024 -0700

    Log error for failed discord message sending.

commit 15784a8
Author: Robin Huang <[email protected]>
Date:   Sat Jun 22 16:30:06 2024 -0700

    Limit security scaning to 5 nodes at once.

commit 64669ca
Author: Robin Huang <[email protected]>
Date:   Sat Jun 22 16:26:30 2024 -0700

    Send new published nodes to discord as well.

commit b771479
Author: Robin Huang <[email protected]>
Date:   Sat Jun 22 16:22:54 2024 -0700

    Filter node versions by status.

commit 91c8121
Author: James Kwon <[email protected]>
Date:   Thu Jun 20 12:07:13 2024 -0400

    Remove active status filter on retrieving latest node (Comfy-Org#51)

    Co-authored-by: James Kwon <[email protected]>

commit 231fc69
Author: James Kwon <[email protected]>
Date:   Thu Jun 20 11:09:21 2024 -0400

    Add more comments to retrieving latest version path with nodes (Comfy-Org#50)

    Co-authored-by: James Kwon <[email protected]>

commit a4c3f9d
Author: Robin Huang <[email protected]>
Date:   Wed Jun 19 16:57:36 2024 -0700

    Add flagged node version to api type.

commit 7bc7d36
Author: Robin Huang <[email protected]>
Date:   Wed Jun 19 16:56:34 2024 -0700

    Fix generated file.

commit 5fbef15
Author: Robin Huang <[email protected]>
Date:   Tue Jun 18 17:09:09 2024 -0700

    Take list of statuses for list node version.

commit 6b27d96
Author: Robin Huang <[email protected]>
Date:   Wed Jun 19 16:41:02 2024 -0700

    List All Node Versions API (Comfy-Org#49)

    * Take list of statuses for list node version.

    * List all node versions.

    * Lower page size.

    * Add maximum comment.

    * Fix limit issue.

    * Fix test.

commit 5410d6b
Author: Robin Huang <[email protected]>
Date:   Tue Jun 18 15:35:38 2024 -0700

    Add security scan endpoint. (Comfy-Org#48)

commit 0ba4833
Author: James Kwon <[email protected]>
Date:   Mon Jun 17 10:08:20 2024 -0400

    Refactor authz (Comfy-Org#47)

commit 1369af7
Author: James Kwon <[email protected]>
Date:   Sun Jun 16 12:36:35 2024 -0400

    Moving some files for metric related code (Comfy-Org#46)

    * Moving some files for metric related code

    * fmt

    * fix tests

commit 192b63a
Author: James Kwon <[email protected]>
Date:   Sun Jun 16 12:19:50 2024 -0400

    Refactor to handle authorization in middleware for all registry endpoints (Comfy-Org#45)

    * Refactor to handle authorization in middleware for all registry endpoints

    * fmt

commit 431070f
Author: Robin Huang <[email protected]>
Date:   Sat Jun 15 16:01:57 2024 -0700

    Tell user about constraint errors for node publishing failures.

commit a78370e
Author: Robin Huang <[email protected]>
Date:   Sat Jun 15 15:46:28 2024 -0700

    Return publisher status in API. (Comfy-Org#44)

    * Return publisher status in API.

    * update.

    * Fix test.

commit 93c6877
Author: Robin Huang <[email protected]>
Date:   Sat Jun 15 15:36:43 2024 -0700

    Add status reason field on node_version. (Comfy-Org#43)

    * Add status reason field on node_version.

    * Udpate.

    * Add migration.

    * Add status reason in response.

    * tewsts.

commit 5eeefb9
Author: James Kwon <[email protected]>
Date:   Sat Jun 15 18:16:25 2024 -0400

    Add category and status_detail fields to node (Comfy-Org#42)

    * Add category and status_detail fields to node

    * resolve conflict

commit 9144072
Author: Robin Huang <[email protected]>
Date:   Sat Jun 15 15:07:59 2024 -0700

    Return the latest active version of a node. (Comfy-Org#41)

    * Get latest active version.

    * Fix bug.

commit 694a567
Author: Robin Huang <[email protected]>
Date:   Sat Jun 15 14:49:39 2024 -0700

    Add admin endpoint to update node version status. (Comfy-Org#40)

    * Add admin endpoint to update node version status.

    * Don't include download url if node version is not active.

    * Approve node with admin endpoint.

commit 0a3293b
Author: James Kwon <[email protected]>
Date:   Sat Jun 15 17:08:06 2024 -0400

    Check publisher banned status when publishing node version (Comfy-Org#39)

commit f11fa72
Author: James Kwon <[email protected]>
Date:   Sat Jun 15 16:41:17 2024 -0400

    Refactor authentication middleware (Comfy-Org#38)

commit 70189ff
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 20:13:57 2024 -0400

    Bypass authorization (Comfy-Org#36)

    * Bypass authorization for non-write operations for non-logged in users

    * Disable authorization middleware & jwt wrapper middleware

commit 7dc4782
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 18:13:56 2024 -0400

    Bypass authorization for non-write operations for non-logged in users (Comfy-Org#35)

commit 9a84b09
Author: Robin Huang <[email protected]>
Date:   Fri Jun 14 14:53:22 2024 -0700

    Add node version status. Default: pending (Comfy-Org#33)

    * Add node version status. Default: pending

    * Return status in mapper.

    * Fixed mapper.

commit 4afe2b3
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 17:42:04 2024 -0400

    Add JWT_SECRET environment variables to staging & prod deployment (Comfy-Org#34)

commit 38a429d
Author: Robin Huang <[email protected]>
Date:   Fri Jun 14 14:24:30 2024 -0700

    Make default node status active instead of pending. (Comfy-Org#32)

    * Make default node status active.

    * Remove pending node state.

commit c839360
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 10:59:51 2024 -0400

    Creating a new script to ban nodes (Comfy-Org#30)

commit a7a7ae9
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 10:54:46 2024 -0400

    Implement an endpoint to ban a node (Comfy-Org#28)

commit d5bcc69
Author: James Kwon <[email protected]>
Date:   Fri Jun 14 09:40:50 2024 -0400

    Ban Publisher (Comfy-Org#24)

commit 7b4e03f
Author: Robin Huang <[email protected]>
Date:   Thu Jun 13 16:25:11 2024 -0700

    Add node state column for security reviews. (Comfy-Org#25)

    * Add node state for security reviews.

    * Add staging/prod migration files.

commit 75c33ec
Author: James Kwon <[email protected]>
Date:   Wed Jun 12 19:16:35 2024 -0400

    add cusstom metric (Comfy-Org#23)

commit a00163a
Author: Robin Huang <[email protected]>
Date:   Tue Jun 11 12:08:21 2024 -0700

    Add comfy.org as a valid CORs origin.

commit d7d2b2b
Author: James Kwon <[email protected]>
Date:   Mon Jun 10 22:59:50 2024 +0200

    Implement tracking install and reviews (Comfy-Org#19)

commit a8084f8
Author: Robin Huang <[email protected]>
Date:   Mon Jun 3 11:44:53 2024 -0700

    Limit description length for node.

commit dae2fbb
Author: Robin Huang <[email protected]>
Date:   Mon Jun 3 11:36:46 2024 -0700

    Improve node id validation error message. (Comfy-Org#20)

commit 5224d14
Author: James Kwon <[email protected]>
Date:   Fri May 31 19:08:43 2024 -0400

    Implement a new endpoint to search nodes (Comfy-Org#18)

commit e1dcf09
Author: James Kwon <[email protected]>
Date:   Wed May 29 22:34:50 2024 -0400

    Add a bit more logging to cicd endpoints (Comfy-Org#17)

commit e7b504c
Author: James Kwon <[email protected]>
Date:   Wed May 29 22:31:21 2024 -0400

    Handle duplicate node id and mark it as client error (Comfy-Org#16)

commit ba81905
Author: James Kwon <[email protected]>
Date:   Tue May 28 18:36:05 2024 -0400

    Add integration test for cicd endpoints (Comfy-Org#15)

commit b85c055
Author: James Kwon <[email protected]>
Date:   Tue May 28 18:29:52 2024 -0400

    Revert test schema change (Comfy-Org#13)

commit 0b575b2
Author: James Kwon <[email protected]>
Date:   Tue May 28 18:23:31 2024 -0400

    Add additional migration to fix non-null statement (Comfy-Org#14)

commit b0015af
Author: James Kwon <[email protected]>
Date:   Tue May 28 18:14:19 2024 -0400

    Fix prod supbase connection string in build.yaml

commit 8e4f1e4
Author: James Kwon <[email protected]>
Date:   Tue May 28 18:07:43 2024 -0400

    Test adding a test_field for versioned migration changes (Comfy-Org#12)

commit e426869
Author: James Kwon <[email protected]>
Date:   Tue May 28 16:25:26 2024 -0400

    Enable versioned migration on prod (Comfy-Org#11)

commit dcd6d29
Author: James Kwon <[email protected]>
Date:   Tue May 28 15:03:44 2024 -0400

    Increase the buffer time to report metrics on GCP (Comfy-Org#10)

commit 1466788
Author: Robin Huang <[email protected]>
Date:   Mon May 27 12:22:24 2024 -0700

    Move slack webhook url to secret manager. (Comfy-Org#8)

commit ab569ae
Author: James Kwon <[email protected]>
Date:   Sun May 26 13:43:10 2024 -0400

    Trigger anohter build

commit 1ab01df
Author: James Kwon <[email protected]>
Date:   Sun May 26 12:43:04 2024 -0400

    Change to HTTP git URL

commit 1b7b33c
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:44:03 2024 -0400

    attempt to fix directory issue in cloudbuild.yaml

commit 6545899
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:41:55 2024 -0400

    fix db_connection_string secretEnv

commit 6a6b228
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:41:17 2024 -0400

    fix git clone issue

commit 89d975c
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:35:54 2024 -0400

    clone github repository for migration file access

commit 48c7225
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:21:34 2024 -0400

    Fixing secretManager fetching syntax

commit 94c2858
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:19:47 2024 -0400

    Fixing secretManager fetching syntax

commit 74d5bef
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:15:41 2024 -0400

    Use availableSecrets:secretManager feature in cloudbuild to retrieve secrets

commit 7e34672
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:08:46 2024 -0400

    Fix logic to fetch secret in cloudbuily.yaml file (Comfy-Org#7)

commit 3cb6bea
Author: James Kwon <[email protected]>
Date:   Sun May 26 11:04:57 2024 -0400

    Fix logic to fetch secret in cloudbuily.yaml file (Comfy-Org#6)

commit 4741922
Author: James Kwon <[email protected]>
Date:   Sun May 26 10:59:37 2024 -0400

    Fix logic to fetch secret in cloudbuily.yaml file (Comfy-Org#5)

commit b5f7a4c
Author: James Kwon <[email protected]>
Date:   Sun May 26 10:56:40 2024 -0400

    Capture latest ent schema state in migration file + applying atlas migration on staging environment (Comfy-Org#4)

commit 8407617
Author: James Kwon <[email protected]>
Date:   Sun May 26 09:40:47 2024 -0400

    Batch metrics sending to GCP (Comfy-Org#3)

commit f957fd3
Author: Robin Huang <[email protected]>
Date:   Sat May 25 13:36:59 2024 -0700

    Fixed: Update slack webhook url.

commit 56bc58d
Author: Robin Huang <[email protected]>
Date:   Fri May 24 10:56:58 2024 -0700

    Remove minscale. Causing errors:

    rror deploying Cloud Run Service: googleapi: Error 400: The feature 'Per-service minimum instances' is not supported in the declared launch stage on resource staging-comfy-backend.

commit fc78c2e
Author: Yoland Yan <[email protected]>
Date:   Fri May 24 07:56:12 2024 -0700

    Update README.md

commit ade516f
Author: Robin Huang <[email protected]>
Date:   Thu May 23 18:20:31 2024 -0700

    Update overview.

commit 80f5d43
Author: Robin Huang <[email protected]>
Date:   Thu May 23 18:17:36 2024 -0700

    Update README.

commit 9092b50
Author: Robin Huang <[email protected]>
Date:   Thu May 23 18:14:36 2024 -0700

    Update secret scanner workflow name.

commit 6f48c1e
Author: Robin Huang <[email protected]>
Date:   Thu May 23 18:13:58 2024 -0700

    Add secret scanner.

commit 711710f
Author: Yoland Y <[email protected]>
Date:   Thu May 23 18:12:58 2024 -0700

    LICENSE

commit 0d612af
Author: Robin Huang <[email protected]>
Date:   Thu May 23 17:04:54 2024 -0700

    Add google cloud run minScale annotation.
  • Loading branch information
@snomiao
snomiao committed Jul 15, 2024
1 parent e375b31 commit 4a2a504
Show file tree
Hide file tree
Showing 140 changed files with 19,695 additions and 3,994 deletions.
62 changes: 62 additions & 0 deletions .github/workflows/db-migration-presubmit.yaml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
name: Database schema migration check
on:
# Run whenever code is changed in the main branch,
push:
branches:
- main
# Run on PRs where something changed under the `ent/migrate/migrations/` directory.
pull_request:
paths:
- 'ent/**'
jobs:
migration-check:
services:
# Spin up a postgres:10 container to be used as the dev-database for analysis.
postgres:
image: postgres:10
env:
POSTGRES_DB: test
POSTGRES_PASSWORD: pass
ports:
- 5432:5432
options: >-
--health-cmd pg_isready
--health-interval 10s
--health-timeout 5s
--health-retries 5
runs-on: ubuntu-latest
steps:
- uses: actions/[email protected]
with:
fetch-depth: 0 # Mandatory unless "latest" is set below.

# doesn't seem to work - does not recognize migrations files.
# - uses: ariga/[email protected]
# with:
# dir: ent/migrate/migrations
# dir-format: golang-migrate # Or: atlas, goose, dbmate
# dev-url: postgres://postgres:pass@localhost:5432/test?sslmode=disable

- name: Check for migration changes
id: check_migrations
run: |
# List files changed in the PR
echo "Checking for changes between ${{ github.event.pull_request.base.sha }} and ${{ github.sha }}"
changed_files=$(git diff --name-only ${{ github.event.pull_request.base.sha }} ${{ github.sha }})
echo "Changed files: $changed_files"
# Check for changes in 'ent/schema'
schema_changes=$(echo "$changed_files" | grep '^ent/schema' || true)
echo "Schema changes: $schema_changes"
# Check for changes in 'ent/migrate/migrations'
migration_changes=$(echo "$changed_files" | grep '^ent/migrate/migrations' || true)
echo "Migration changes: $migration_changes"
# If there are schema changes but no migration changes, fail the check
if [ -n "$schema_changes" ] && [ -z "$migration_changes" ]; then
echo "::error::Changes in 'ent/schema' require corresponding changes in 'ent/migrate/migrations'"
exit 1
else
echo "Check passed: Schema changes are accompanied by migration changes."
fi
2 changes: 1 addition & 1 deletion .github/workflows/logging-presubmit.yml
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: semgrep
name: Logging check
on:
push:
branches:
Expand Down
37 changes: 0 additions & 37 deletions .github/workflows/migration-ci.yaml
View file

This file was deleted.

19 changes: 19 additions & 0 deletions .github/workflows/secret-scanning.yml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Secret Scanning
on:
push:
branches:
- main
pull_request:

jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4
with:
fetch-depth: 0
- name: Secret Scanning
uses: trufflesecurity/trufflehog@main
with:
extra_args: --only-verified
Loading

0 comments on commit 4a2a504

Please sign in to comment.