Fix warnings when generating Python dist #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling setup.py directly is deprecated and produces a warning. See: - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html - https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#what-commands-should-be-used-instead
Quoting the warning message: > With Python 2.7 end-of-life, support for building universal wheels > (i.e., wheels that support both Python 2 and Python 3) > is being obviated. > Please discontinue using this option, or if you still need it, > file an issue with pypa/setuptools describing your use case. > > By 2025-Aug-30, you need to update your project and remove deprecated calls > or your builds will no longer be supported.
|
I think it's reasonable to drop Python 2 support here at this point - after all I proposed we stop actively supporting Python 2 about 3½ years ago (https://lists.tartarus.org/pipermail/snowball-discuss/2021-August/001721.html) and have had no negative feedback at all. Also if anyone really wants to use current snowball to generate code to use with Python 2, the generated code should still be compatible - they'll just need to manage putting the generated files somewhere that their Python 2 interpreter can find them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
make dist_libstemmer_pythonin the current master, these two warnings are printed:and
This PR has the minimal changes required to fix these warnings.
If you agree, I can improve our Python packaging further in the next PRs:
pyupgradetool.setup.pyandsetup.cfgtopyproject.toml. There is a dynamic part of metadata (list of languages), but we can either keep that part insetup.py(and move the static part only), or makepyproject.tomlgenerated by GNUmakefile.