-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SNOW-1669514] Honor the Valuer/Stringer methods to resolve #1209 #1211
[SNOW-1669514] Honor the Valuer/Stringer methods to resolve #1209 #1211
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! Can you take a look at my comments?
3e86c6e
to
8d58f43
Compare
6fad842
to
c3e9be6
Compare
@sfc-gh-pfus added tests to structured R/W and Driver. Will attempt to run the tests |
@ChronosMasterOfAllTime good job! But correct me if I'm wrong, but as far as I can see, there are only tests for embedding uuid in structured types and not as inserts into/selects from a regular column? Can you add such a test case as well (probably somewhere in driver_test.go)? |
There is a test added in driver_test.go |
@sfc-gh-pfus need support on this one: Getting the following error:
|
I tried it locally and it worked. I started build on Github Actions, let's check it. By looking at the message - I believe it because you didn't add this UUID to object definition in table, but in the current version it is present, so let's hope it works. |
What I mean is I tried this on a clean branch and got the same error. Is it something to do with my snowflake instance? (I finally got the ability to test against our QA env) |
So probably yes, probably you don't have access to some features. But it works on CI, so it is good enough. |
219942f
to
7b0e858
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last comment and we are good to go!
b17b0aa
to
22740b4
Compare
248e392
to
3830f56
Compare
@sfc-gh-pfus doh! linter errors fixed |
@sfc-gh-dheyman I ran the linter locally and noticed the |
Part of the journey is the end. @ChronosMasterOfAllTime, thank you very much for all the work you put into this PR and for your huge amount of patience! |
Description
SNOW-1669514 - Solve the issue with UUID getting double quoted due to new array function #1209
This adds the ability to check the valuer/stringer interfaces exists
Checklist
Proof test fails.