[SNOW-1346233] Tests for authentication methods (external browser, oauth, okta, keypair) #1264
+514
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1264 +/- ##
=======================================
Coverage 82.20% 82.20%
=======================================
Files 55 55
Lines 13547 13547
=======================================
Hits 11136 11136
Misses 2411 2411 ☔ View full report in Codecov by Sentry. |
sfc-gh-pcyrek
changed the title
sfc-gh-pcyrek
changed the title
sfc-gh-pfus
reviewed
Dec 11, 2024
sfc-gh-pcyrek
changed the title
sfc-gh-pfus
reviewed
Dec 18, 2024
…ests' into pcyrek-golang-external-browser-tests
…ests' into pcyrek-golang-external-browser-tests
sfc-gh-pfus
reviewed
Dec 19, 2024
sfc-gh-pfus
approved these changes
Dec 19, 2024
|
|
||
| func TestOktaWrongURL(t *testing.T) { | ||
| cfg := setupOktaTest(t) | ||
| invalidAddress, err := url.Parse("https://fake-account-0000.okta.com") |
There was a problem hiding this comment.
url is the same as in previous test, is it ok ?
sfc-gh-akolodziejczyk
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SNOW-1346233 Tests for authentication methods (External browser, oauth, okta). This PR contains changes for authentication tests with external browser, oauth and okta in docker container.
Checklist