Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1789753: Support GCS region specific endpoint #1280

Merged
merged 9 commits into from
Dec 20, 2024

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy commented Dec 17, 2024

Description

SNOW-1789753Please explain the changes you made here.

Checklist

  • Created tests which fail without the change (if possible)
  • Extended the README / documentation, if necessary

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy marked this pull request as ready for review December 18, 2024 03:59
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy requested a review from a team as a code owner December 18, 2024 03:59
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.27%. Comparing base (45b3d45) to head (597fefa).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1280      +/-   ##
==========================================
+ Coverage   82.23%   82.27%   +0.04%     
==========================================
  Files          55       55              
  Lines       13537    13563      +26     
==========================================
+ Hits        11132    11159      +27     
+ Misses       2405     2404       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-dprzybysz
Copy link
Contributor

@sfc-gh-ext-simba-jy Can we close #1271 then?

@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy merged commit 8257f91 into master Dec 20, 2024
34 of 37 checks passed
@sfc-gh-ext-simba-jy sfc-gh-ext-simba-jy deleted the SNOW-1789753 branch December 20, 2024 18:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants