Implement Easy Logging using a config file #747
+1,050
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-jszczerbinski
requested changes
Oct 14, 2024
sfc-gh-jszczerbinski
requested changes
Nov 28, 2024
sfc-gh-jszczerbinski
requested changes
Dec 11, 2024
sfc-gh-ext-simba-nl
requested review from
sfc-gh-dprzybysz and
sfc-gh-jszczerbinski
cpp/lib/ClientConfigParser.cpp
Outdated
| return clientConfigEnv; | ||
| } | ||
|
|
||
| // 3. Try DLL library dir |
There was a problem hiding this comment.
Let's remove DLL (library seems to be enough) and rename functions and variables below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SNOW-981602: Implement Easy Logging using a config file
Add several new global attributes:
SF_GLOBAL_CLIENT_CONFIG_FILE: To set the client config file so libsnowflakeclient knows where to look for the config file
SF_GLOBAL_LOG_LEVEL: To allow the user to get the log level since libsnowflakeclient handles log setup
SF_GLOBAL_LOG_PATH: To allow the user to get the log path