SNOW-715551: Support authentication with OKTA #799
Conversation
|
|
||
| //m_appID = m_connection->application_name; | ||
| //m_appVersion = m_connection->application_version; | ||
| m_appID = "ODBC"; |
There was a problem hiding this comment.
Is this feature needs server change and here is the temporary workaround to pass the test?
If so please comment in the ticket/PR and add TODO comment here to ensure this will be removed before release.
There was a problem hiding this comment.
Added the comment.
| @@ -198,6 +198,12 @@ cJSON *STDCALL create_auth_json_body(SF_CONNECT *sf, | |||
| // update authentication information to body | |||
| auth_update_json_body(sf, body); | |||
|
|
|||
| if (AUTH_OAUTH == getAuthenticatorType(sf->authenticator)) | |||
There was a problem hiding this comment.
Why we have this logic here not included in auth_update_json_body ?
There was a problem hiding this comment.
I moved this code because of #750 (comment).
| @@ -160,36 +160,72 @@ void test_mfa_connect_with_duo_passcodeInPassword(void** unused) | |||
| snowflake_term(sf); | |||
| } | |||
|
|
|||
| void test_okta_connect(void** unused) | |||
There was a problem hiding this comment.
Besides manual function test, can we have unit test cases in automation test? giving test cases in ODBC and libsfclient ones you made as examples.
There was a problem hiding this comment.
I made testing cases in the test_unit_okta.cpp
No description provided.