Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-715619: Support authentication with external browser #813

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sfc-gh-ext-simba-jy
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 19.48310% with 405 lines in your changes missing coverage. Please review.

Project coverage is 77.30%. Comparing base (9f9d51d) to head (e982000).

Files with missing lines Patch % Lines
cpp/lib/IAuth.cpp 10.72% 283 Missing ⚠️
cpp/lib/Authenticator.cpp 37.50% 85 Missing ⚠️
cpp/lib/SnowflakeUtil.cpp 41.66% 14 Missing ⚠️
lib/client.c 18.18% 9 Missing ⚠️
include/snowflake/IAuth.hpp 0.00% 5 Missing ⚠️
lib/connection.c 16.66% 5 Missing ⚠️
lib/snowflake_util.h 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #813      +/-   ##
==========================================
- Coverage   80.52%   77.30%   -3.22%     
==========================================
  Files         104      107       +3     
  Lines        9223     9695     +472     
==========================================
+ Hits         7427     7495      +68     
- Misses       1796     2200     +404     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant