SNOW-1621763 update example for na + spcs upgrade #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yxu
commented
Aug 14, 2024
| @@ -1,5 +1,4 @@ | |||
| set -e | |||
| snow sql -f "prepare/spcs_setup.sql" | |||
There was a problem hiding this comment.
We do not need this anymore. Please see https://snowflakecomputing.atlassian.net/browse/SNOW-1527720
sfc-gh-yxu
force-pushed
the
yxu_SNOW-1621763_na_spcs_upgrade
branch
from
95dc76e
to
384b058
Compare
sfc-gh-yxu
commented
Aug 16, 2024
spcs-three-tier/app/setup.sql
Outdated
| --wait for 300 seconds, but it will stop if two services have READY status, | ||
| -- or any of the services has the FAILED status. | ||
| select system$wait_for_services(300, 'app_public.backend', 'app_public.frontend'); | ||
|
|
There was a problem hiding this comment.
Handle the failure to create service
Should throw exception to force app failure?
There was a problem hiding this comment.
Do you know what the best practice is from the NA+SPCS team? That's what we want to have here.
There was a problem hiding this comment.
Had a test and found out that if the service was not available or not ready, it will fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.