Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1333462 update libsfc 1.0.11 built with gcc8 #384

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

SimbaGithub
Copy link
Collaborator

@SimbaGithub SimbaGithub commented May 14, 2024

Update libsfclient 1.0.11 built with gcc8

@SimbaGithub SimbaGithub requested a review from a team as a code owner May 14, 2024 21:04
@SimbaGithub SimbaGithub marked this pull request as draft May 14, 2024 21:04
Copy link

gitguardian bot commented May 14, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@SimbaGithub SimbaGithub marked this pull request as ready for review June 8, 2024 01:03
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR name with issue id and version 1.0.11 of libsnowflakeclient

@sfc-gh-dprzybysz
Copy link
Collaborator

Please check also include files of libsnowflakeclient - some files seems to be missing

@SimbaGithub SimbaGithub changed the title update libsfc 1.0.10 built with gcc8 update libsfc 1.0.11 built with gcc8 Jun 10, 2024
@SimbaGithub SimbaGithub changed the title update libsfc 1.0.11 built with gcc8 SNOW-1333462 update libsfc 1.0.11 built with gcc8 Jun 11, 2024
@SimbaGithub SimbaGithub merged commit 369e2a7 into master Jun 11, 2024
12 checks passed
@SimbaGithub SimbaGithub deleted the buid-with-gcc8 branch June 11, 2024 15:07
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants