Generalize names used in the artifact processor pipeline #1933
+5,954
−2,681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-bdufour
commented
Dec 6, 2024
Comment on lines
+25
to
26
| class ArtifactProcessorContext: | ||
| package_name: str |
There was a problem hiding this comment.
NB: this will be refactored next
* Added glob support for Snowpark and Streamlit * Added glob support for Snowpark and Streamlit * Added glob support for Snowpark and Streamlit * Changed PathMapping.src to Path * Changes after review * Changes after review 2 * Revert "Changed PathMapping.src to Path" This reverts commit 3eb543d. * Changes after review 3 * Changes after review 4 * Added full global support * Renamed feature flag and added release notes * Removed or None
Fix feature branch gates
sfc-gh-bdufour
force-pushed
the
bdufour-artifacts-generalize-names
branch
from
4753ff4 to
17e4b2a
Compare
sfc-gh-bdufour
changed the base branch from
bdufour/unification-artifacts
to
features/unification-artifacts
sfc-gh-bdufour
changed the base branch from
features/unification-artifacts
to
main
sfc-gh-bdufour
changed the base branch from
main
to
features/unification-artifacts
sfc-gh-bdufour
changed the base branch from
features/unification-artifacts
to
main
sfc-gh-bdufour
changed the base branch from
main
to
features/unification-artifacts
sfc-gh-melnacouzi
previously approved these changes
Dec 11, 2024
sfc-gh-astus
force-pushed
the
features/unification-artifacts
branch
2 times, most recently
from
2bee685 to
c15cca5
Compare
sfc-gh-astus
force-pushed
the
features/unification-artifacts
branch
4 times, most recently
from
517a85f to
878d715
Compare
sfc-gh-astus
force-pushed
the
features/unification-artifacts
branch
3 times, most recently
from
1a17d7e to
6ef2d27
Compare
sfc-gh-astus
dismissed
sfc-gh-melnacouzi’s stale review
The base branch was changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-review checklist
Changes description
Refactoring names using the processor pipeline to be more general. This is in preparation for moving processor logic to a common module (and out of native apps)
Verified through
grepthat all occurrences of the terms being changes here have been replaced.