Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notebook to supported objects #2033

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add notebook to supported objects #2033

merged 3 commits into from
Jan 30, 2025

Conversation

sfc-gh-pczajka
Copy link
Contributor

@sfc-gh-pczajka sfc-gh-pczajka commented Jan 30, 2025 •
edited
Loading

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually on MacOS.
  • I've confirmed that my changes are working by executing CLI's commands manually on Windows.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Add notebook to snow object commands

@sfc-gh-pczajka sfc-gh-pczajka requested review from a team as code owners January 30, 2025 12:20
sfc-gh-astus
sfc-gh-astus reviewed Jan 30, 2025
View reviewed changes
tests/object/__snapshots__/test_object.ambr Outdated
+--------+
| status |
|--------|
| n |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be just n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :D

sfc-gh-astus
sfc-gh-astus reviewed Jan 30, 2025
View reviewed changes
tests/object/__snapshots__/test_object.ambr
@@ -65,6 +65,17 @@

'''
# ---
# name: test_describe[notebook-notebook_example]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List is missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list doesn't use snapshots:

➜ pytest object/test_object.py::test_show
================================== test session starts ===================================
...
object/test_object.py::test_show[notebook-notebooks] PASSED              [ 55%]
...

@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) January 30, 2025 13:49
@sfc-gh-pczajka sfc-gh-pczajka merged commit 9e3c086 into main Jan 30, 2025
20 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the SNOW-1903812-add-notebook-to-supported-objects branch January 30, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-astus sfc-gh-astus sfc-gh-astus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-pczajka @sfc-gh-astus