-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove recursive search for snowflake.yml #705
Remove recursive search for snowflake.yml #705
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One potential cleanup
search_path = os.getcwd() | ||
if project_arg: | ||
search_path = os.path.abspath(project_arg) | ||
project_root = DefinitionManager.find_project_root(Path(search_path)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfc-gh-turbaszek can we remove the find_project_root
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NADE commands are using it for checking if project is not within another project
Pre-review checklist
Changes description
...