Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove recursive search for snowflake.yml #705

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

...

Copy link
Contributor

@sfc-gh-cgorrie sfc-gh-cgorrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential cleanup

search_path = os.getcwd()
if project_arg:
search_path = os.path.abspath(project_arg)
project_root = DefinitionManager.find_project_root(Path(search_path))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-turbaszek can we remove the find_project_root as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NADE commands are using it for checking if project is not within another project

@sfc-gh-turbaszek sfc-gh-turbaszek enabled auto-merge (squash) January 31, 2024 09:25
@sfc-gh-turbaszek sfc-gh-turbaszek merged commit e4e83cd into main Jan 31, 2024
16 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the remove-recursive-search-for-project-file branch January 31, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants