Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-834781: Remove log4net and delegate logging to consumers #1057

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

SNOW-834781: Remove log4net and delegate logging to consumers #1057

wants to merge 4 commits into from
+1,037 −2,624

Conversation

sfc-gh-ext-simba-lf
Copy link
Collaborator

Description

Remove the log4net dependency and replace with the Microsoft logging interface so users can plug in their own custom loggers

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-ext-simba-lf
SNOW-834781: Remove log4net and delegate logging to consumers
650bb43
@sfc-gh-ext-simba-lf
SNOW-834781: Refactor/add tests
f0484f6
@sfc-gh-ext-simba-lf
Merge branch 'master' of https://github.com/snowflakedb/snowflake-con…
83e56ef 
…nector-net into SNOW-834781-Remove-log4net

# Conflicts:
#	Snowflake.Data.Tests/IntegrationTests/SFConnectionIT.cs
#	Snowflake.Data.Tests/UnitTests/Configuration/EasyLoggingConfigFinderTest.cs
#	Snowflake.Data/Core/ArrowResultSet.cs
#	Snowflake.Data/Core/FileTransfer/StorageClient/SFGCSClient.cs
#	Snowflake.Data/Core/HttpUtil.cs
#	Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs
#	Snowflake.Data/Core/SFStatement.cs
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Nov 11, 2024
Open
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 84.31734% with 85 lines in your changes missing coverage. Please review.

Project coverage is 85.86%. Comparing base (05da00a) to head (0ab8c66).

Files with missing lines Patch % Lines
...Core/Authenticator/ExternalBrowserAuthenticator.cs 6.25% 15 Missing ⚠️
Snowflake.Data/Core/SFStatement.cs 35.00% 11 Missing and 2 partials ⚠️
...lake.Data/Core/FileTransfer/SFFileTransferAgent.cs 57.14% 12 Missing ⚠️
Snowflake.Data/Core/Session/SFSession.cs 66.66% 9 Missing and 1 partial ⚠️
Snowflake.Data/Core/SFBlockingChunkDownloaderV3.cs 95.83% 3 Missing and 3 partials ⚠️
...ke.Data/Core/Authenticator/KeyPairAuthenticator.cs 25.00% 3 Missing ⚠️
Snowflake.Data/Core/Session/SFSessionProperty.cs 82.35% 3 Missing ⚠️
Snowflake.Data/Client/SnowflakeDbConnection.cs 91.30% 2 Missing ⚠️
Snowflake.Data/Client/SnowflakeDbConnectionPool.cs 88.88% 2 Missing ⚠️
Snowflake.Data/Core/ArrowResultSet.cs 60.00% 2 Missing ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
- Coverage   86.24%   85.86%   -0.38%     
==========================================
  Files         121      113       -8     
  Lines       11779    11351     -428     
  Branches     1196     1160      -36     
==========================================
- Hits        10159     9747     -412     
+ Misses       1334     1332       -2     
+ Partials      286      272      -14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sfc-gh-ext-simba-lf