SNOW-1545648: Fix PUT command error if file path contains spaces and single quotes #1066
+98
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 86.23% 86.30% +0.06%
==========================================
Files 121 121
Lines 11845 11849 +4
Branches 1212 1213 +1
==========================================
+ Hits 10215 10226 +11
+ Misses 1338 1334 -4
+ Partials 292 289 -3 ☔ View full report in Codecov by Sentry. |
…nector-net into SNOW-1545648-PUT-Space-Error
…nector-net into SNOW-1545648-PUT-Space-Error
sfc-gh-knozderko
approved these changes
Dec 9, 2024
| { | ||
| // Extract file path from PUT command: | ||
| // E.g. "PUT file://C:<path-to-file> @DB.SCHEMA.%TABLE;" | ||
| int startIndex = query.IndexOf("file://") + "file://".Length; | ||
| int endIndex = query.Substring(startIndex).IndexOf('@') - 1; | ||
| string filePath = query.Substring(startIndex, endIndex); | ||
| string filePath = query.Substring(startIndex, endIndex).Trim(); |
There was a problem hiding this comment.
maybe TrimEnd() would be better because we just want to trim trailing spaces.
sfc-gh-pbulawa
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix PUT command error if file path contains spaces and single quotes
Checklist
dotnet test)