Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "https://" prefix even if the endpoint isn't surrounded by brackets #800

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

darrellzook
Copy link

Description

This currently throws an exception when setting the ServiceURL property if the endpoint is not surrounded by brackets. I moved the code that adds the "https://" prefix outside of the code that removes the surrounding brackets so that it is always included when there's an endpoint.

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

…ackets. Otherwise this results in an invalid ServiceURL exception
@darrellzook darrellzook requested a review from a team as a code owner October 23, 2023 21:08
@github-actions
Copy link

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


Darrell Zook seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@darrellzook
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@darrellzook
Copy link
Author

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant